Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request: Introduce optional caching to ExecuteScalar* methods #648

Closed
Swoorup opened this issue Nov 26, 2020 · 2 comments
Closed

Request: Introduce optional caching to ExecuteScalar* methods #648

Swoorup opened this issue Nov 26, 2020 · 2 comments
Assignees
@mikependon
Labels
deployed Feature or bug is deployed at the current release fixed The bug, issue, incident has been fixed. pre-discussed Pre-discussed and/or pre-collaborated with the reported request A request from the community.

Comments

@Swoorup
Copy link
Contributor

Swoorup commented Nov 26, 2020

We are using postgis to generate MVT tiles which is binary content.

Example query:

let! tile = conn.ExecuteScalarAsync<byte[]>("select suburbs(@z,@x,@y)", param)

It would be great if we could introduce caching layer for ExecuteScalar* methods as well, as the functions are computationally expensive to calculate.
@mikependon mikependon self-assigned this Nov 26, 2020
@mikependon mikependon added pre-discussed Pre-discussed and/or pre-collaborated with the reported request A request from the community. labels Nov 26, 2020
@mikependon mikependon changed the title Introduce optional caching to ExecuteScalar* methods Request: Introduce optional caching to ExecuteScalar* methods Nov 30, 2020
mikependon added a commit that referenced this issue Nov 30, 2020
@mikependon
#648 - Fixes and Integration Tests for ExecuteScalar Caching.
64215c3
@mikependon mikependon added the fixed The bug, issue, incident has been fixed. label Nov 30, 2020
@mikependon mikependon reopened this Nov 30, 2020
mikependon added a commit that referenced this issue Nov 30, 2020
@mikependon
#648 Added the ExecuteScalar cache functionality for DbRepository and…
8efea20 
… BaseRepository.
@mikependon mikependon added the deployed Feature or bug is deployed at the current release label Dec 3, 2020
@mikependon
Copy link
Owner

The fix is now available at RepoDb v1.12.5-beta4.

@mikependon
Copy link
Owner

Closing this ticket now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikependon mikependon

Labels
deployed Feature or bug is deployed at the current release fixed The bug, issue, incident has been fixed. pre-discussed Pre-discussed and/or pre-collaborated with the reported request A request from the community.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikependon @Swoorup