Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Add the dynamic ExecuteQueryMultiple method in the DbRepository #630

Closed
gkn06 opened this issue Oct 28, 2020 · 7 comments
Closed

Enhancement: Add the dynamic ExecuteQueryMultiple method in the DbRepository #630

gkn06 opened this issue Oct 28, 2020 · 7 comments
Assignees
@mikependon
Labels
deployed Feature or bug is deployed at the current release enhancement New feature or request fixed The bug, issue, incident has been fixed. request A request from the community.

Comments

@gkn06
Copy link

gkn06 commented Oct 28, 2020

@mikependon
Other IDbConnection extended method named ExecuteQueryMultiple is not yet added in the DbRepository.
Is it possible to add that too?

Signature:

public static QueryMultipleExtractor ExecuteQueryMultiple(this IDbConnection connection, string commandText, object param = null, CommandType? commandType = null, int? commandTimeout = null, IDbTransaction transaction = null);

Related to #517

Thanks a lot!
@mikependon mikependon self-assigned this Oct 28, 2020
@mikependon mikependon added enhancement New feature or request request A request from the community. labels Oct 28, 2020
@mikependon mikependon pinned this issue Oct 28, 2020
mikependon added a commit that referenced this issue Oct 28, 2020
@mikependon
#630 - Fixes for the requests on DbRepository.ExecuteQueryMultiple.
4c21e85
@mikependon mikependon added the fixed The bug, issue, incident has been fixed. label Oct 28, 2020
@mikependon
Copy link
Owner

@gkn06 - your request is now available in the master branch, but TBH, I had not tested it yet. Would you like to have a beta release and test it?

@mikependon
Copy link
Owner

This is now deployed at RepoDB v1.12.5-beta1. Can you upgrade and test it there? Thanks

@mikependon mikependon added the deployed Feature or bug is deployed at the current release label Oct 28, 2020
@mikependon mikependon unpinned this issue Oct 28, 2020
@gkn06
Copy link
Author

gkn06 commented Oct 28, 2020

@mikependon Sure. I will test it & let you know asap.

@gkn06
Copy link
Author

gkn06 commented Oct 28, 2020

@mikependon I tested it. Its working perfect 👍.

@mikependon
Copy link
Owner

Thanks, closing this ticket now.

@mikependon
Copy link
Owner

By the way, ensure to always dispose the instance of QueryMultipleExtractor after used so the underlying DbDataReader and DbConnection will also be disposed.

@gkn06
Copy link
Author

gkn06 commented Oct 28, 2020

Thanks much @mikependon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikependon mikependon

Labels
deployed Feature or bug is deployed at the current release enhancement New feature or request fixed The bug, issue, incident has been fixed. request A request from the community.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikependon @gkn06