Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Remove the QueryBuilder on the IStatementBuilder interface methods #1055

Closed
mikependon opened this issue Jul 22, 2022 · 2 comments
Assignees
Labels
breaking-changes A breaking changes (issue, request, enhancement, etc) enhancement New feature or request fixed The bug, issue, incident has been fixed.

Comments

@mikependon
Copy link
Owner

Describe the enhancement

To simplify the calls to the IStatementBuilder methods without requiring the caller to explicitly instantiate the QueryBuilder class, we therefore proposing to remove this argument in all the methods of the Statement Builders.

Current implementation is below.

public virtual string CreateQuery(QueryBuilder queryBuilder,
            string tableName,
            IEnumerable<Field> fields,
            QueryGroup where = null,
            IEnumerable<OrderField> orderBy = null,
            int? top = null,
            string hints = null)

Proposal impelentation is below.

public virtual string CreateQuery(string tableName,
            IEnumerable<Field> fields,
            QueryGroup where = null,
            IEnumerable<OrderField> orderBy = null,
            int? top = null,
            string hints = null)

Additional Context

All the extended libraries (i.e: RepoDb.SqlServer, RepoDb.PostgreSql, RepoDb.MySql, RepoDb.SqLite) must also follow the structure.

Acceptance Criteria

All the existing Unit Tests and Integration Tests must be updated to conform with the proposal and must be executed successfully.

@mikependon mikependon added the enhancement New feature or request label Jul 22, 2022
@mikependon mikependon self-assigned this Jul 22, 2022
@mikependon
Copy link
Owner Author

Related: #1036

@mikependon mikependon added the breaking-changes A breaking changes (issue, request, enhancement, etc) label Jul 22, 2022
@mikependon mikependon pinned this issue Aug 22, 2022
mikependon added a commit that referenced this issue Aug 23, 2022
mikependon added a commit that referenced this issue Aug 23, 2022
mikependon added a commit that referenced this issue Aug 23, 2022
mikependon added a commit that referenced this issue Aug 23, 2022
mikependon added a commit that referenced this issue Aug 23, 2022
Fixes to the enhancement of IStatementBuilder #1055
@mikependon
Copy link
Owner Author

This will be available in the releases > RepoDB v1.12.10.

@mikependon mikependon added the fixed The bug, issue, incident has been fixed. label Aug 24, 2022
@mikependon mikependon unpinned this issue Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-changes A breaking changes (issue, request, enhancement, etc) enhancement New feature or request fixed The bug, issue, incident has been fixed.
Projects
None yet
Development

No branches or pull requests

1 participant