Add Ruby 3.1 support #1472

deivid-rodriguez · 2022-02-16T18:13:11Z

No description provided.

eregon · 2022-02-16T19:52:59Z

I was wondering why the truffleruby job gets cancelled, and found https://github.com/deivid-rodriguez/mail/actions/runs/1853944108

ruby (flavorjones/truffleruby:stable)
The job running on runner Hosted Agent has exceeded the maximum execution time of 5 minutes.
ruby (flavorjones/truffleruby:stable)
The operation was canceled.

So it seems because of the rather low timeout-minutes.
There are also some upcoming truffleruby changes to speed it up in CI and use less memory.
Anyway, seems OK to remove from now, that Docker image was also picking a older TruffleRuby release it seems.

And potentially the CI could (later) run outside Docker now that it doesn't require such ancient Ruby versions like 1.8, which would make the CI faster as well.

.github/workflows/test.yml

deivid-rodriguez · 2022-02-17T12:44:25Z

This is now green and I'm happy with it!

wolak88 · 2022-03-07T14:32:15Z

Is there anything else TBD before merging that to the gem itself?

Thanks for the great job!

deivid-rodriguez · 2022-03-07T14:48:21Z

A maintainer of this gem needs to review the PR. From my side it's ready.

simi · 2022-03-07T16:43:14Z

@mikel @jeremy any chance to get some time to check this? Is there anything I can help with to help maintaining this gem?

eregon · 2022-03-10T13:44:03Z

@deivid-rodriguez FWIW, I think there is no need to depend on the io-wait gem, is there?
Also for context: https://bugs.ruby-lang.org/issues/18591#note-7

Gemfile

mikel · 2022-04-19T05:35:29Z

Let's get #1476 passing CI and merged first, then we can rebase this and move forward @deivid-rodriguez @simi and @voxik

simi · 2022-04-21T11:47:38Z

🙏 time to rebase @deivid-rodriguez

The default RubyGems version on Ruby 2.5 has issues with it.

The released version of `truffleruby` does not work with old versions of Bundler. However, it's not possible to specify a custom version of Bundler in truffleruby, because the `ruby/setup-ruby` will ignore that in the case of `truffleruby-22.0` (the current release) That's in my opinion an issue with `ruby/setup-ruby` because it should respect user's choice when it's explicit. But it's not possible to change that because it was an explicit choice of that library. So as an alternative solution, use `truffleruby-head`, which apparently does not have the issue.

deivid-rodriguez · 2022-04-21T12:49:21Z

This should be ready now!

Gemfile

Mit Ruby 3.1 ist u.a. 'net-smtp' aus den Standardabhängigkeiten entfallen. 'mail' benötigt diese Abhängigkeit und löst diese jedoch erst ab Version 2.8.0 selbst auf (mikel/mail#1472), das bisher noch nicht veröffentlicht wurde (nur als RC1).

johnnyshields · 2022-06-24T03:41:51Z

@mikel Please do the final release of 2.8.0? This issue is causing a problem for many people as you can see in all the references above.

* Update Ruby 3.1.2 Mit Ruby 3.1 ist u.a. 'net-smtp' aus den Standardabhängigkeiten entfallen. 'mail' benötigt diese Abhängigkeit und löst diese jedoch erst ab Version 2.8.0 selbst auf (mikel/mail#1472), das bisher noch nicht veröffentlicht wurde (nur als RC1). Co-authored-by: Niels Bennke <[email protected]>

ghepting · 2022-07-21T00:33:51Z

Is there a stable release with this out yet or just the rc?

ashishra0 · 2022-07-27T15:16:40Z

Folks, I recently upgraded to ruby3.1.1 in my project which sends mail to users and hit a blocker, and to resolve that I need to add the net/smtp gem. Now my question is, do I still need to include that gem in my gemfile?

deivid-rodriguez · 2022-07-27T18:00:40Z

Little has changed, unfortunately. Previously to the rc release, you needed to include net/smtp in your Gemfile. Now you need to either use that workaround or force the rc to be picked up by Bundler (with gem "mail", ">= 2.8.0.rc1" or similar).

Hopefully @mikel will release the final version soon.

johnnyshields · 2022-10-18T07:03:23Z

@mikel any update on this?

Ruby 3.1 removed net-smtp from stdlib which causes a problem when Rails 6 loads the mail gem [1]. Rails 7 has a fix for this [2]. I expect it won't be too long until we drop support for Rails 6 and can remove this. [1]: mikel/mail#1472 [2]: rails/rails@cb44df7

…cies * See mikel/mail#1472 (comment)

…d false accordig to issue mikel/mail#1472

…cies * See mikel/mail#1472 (comment)

* matrix: teamcapybara/capybara#2468 * `nokogiri 🤷 but there's no version constraint anyways * `net-*`: mikel/mail#1472 It's been quite a while so these seem safe to drop

* Remove some explicit dependencies from the gemfile * matrix: teamcapybara/capybara#2468 * `nokogiri 🤷 but there's no version constraint anyways * `net-*`: mikel/mail#1472 It's been quite a while so these seem safe to drop * Run different rails versions tests in parallel Ditch appraisals while we're at it

deivid-rodriguez mentioned this pull request Feb 16, 2022

Add former default gems as a dependency for Ruby 3.1 compatibility #1439

Closed

deivid-rodriguez force-pushed the ruby-31-support branch from da1de3d to cc5dd2c Compare February 17, 2022 09:55

eregon reviewed Feb 17, 2022

View reviewed changes

.github/workflows/test.yml Outdated Show resolved Hide resolved

deivid-rodriguez force-pushed the ruby-31-support branch 3 times, most recently from 24cb453 to 30d1819 Compare February 17, 2022 12:43

simi approved these changes Feb 23, 2022

View reviewed changes

deivid-rodriguez force-pushed the ruby-31-support branch 3 times, most recently from 316d8c9 to 508f432 Compare March 10, 2022 14:32

voxik reviewed Mar 23, 2022

View reviewed changes

Gemfile Outdated Show resolved Hide resolved

This was referenced Apr 19, 2022

Add Mail::YAML#load compatible with Psych 3.x and Psych 4.x. #1476

Closed

Require Ruby >= 2.5, add Psych 4 support, and get CI green #1478

Merged

deivid-rodriguez changed the title ~~Add Ruby 3.1 support, require Ruby >= 2.5, and get CI green~~ Add Ruby 3.1 support Apr 20, 2022

deivid-rodriguez force-pushed the ruby-31-support branch from 508f432 to 3d577d0 Compare April 21, 2022 11:56

Use a RubyGems version in CI that supports Psych 4

95f54ab

The default RubyGems version on Ruby 2.5 has issues with it.

deivid-rodriguez force-pushed the ruby-31-support branch from 3d577d0 to 6182cf0 Compare April 21, 2022 12:03

deivid-rodriguez force-pushed the ruby-31-support branch 2 times, most recently from 5c24652 to 63a749c Compare April 21, 2022 12:49

eregon reviewed Apr 21, 2022

View reviewed changes

Gemfile Outdated Show resolved Hide resolved

eddierubeiz mentioned this pull request Jun 23, 2022

[WIP] hold backpsych to version 3 in Gemfile.extra? samvera/questioning_authority#366

Closed

eddierubeiz mentioned this pull request Jun 24, 2022

[WIP] Support for Rails 3.0 and 3.1 samvera/questioning_authority#365

Closed

r4do mentioned this pull request Jul 22, 2022

Add ActionMailer support railsware/mailtrap-ruby#3

Merged

graalvmbot pushed a commit to oracle/truffleruby that referenced this pull request Oct 26, 2022

Use a more recent version of the mail gem to have the corect dependen…

cf2e324

…cies * See mikel/mail#1472 (comment)

graalvmbot pushed a commit to oracle/truffleruby that referenced this pull request Oct 26, 2022

Use a more recent version of the mail gem to have the corect dependen…

f1f12eb

…cies * See mikel/mail#1472 (comment)

graalvmbot pushed a commit to oracle/truffleruby that referenced this pull request Oct 28, 2022

Use a more recent version of the mail gem to have the corect dependen…

3652f16

…cies * See mikel/mail#1472 (comment)

graalvmbot pushed a commit to oracle/truffleruby that referenced this pull request Nov 1, 2022

Use a more recent version of the mail gem to have the corect dependen…

4741246

…cies * See mikel/mail#1472 (comment)

graalvmbot pushed a commit to oracle/truffleruby that referenced this pull request Nov 2, 2022

Use a more recent version of the mail gem to have the corect dependen…

c83adde

…cies * See mikel/mail#1472 (comment)

graalvmbot pushed a commit to oracle/truffleruby that referenced this pull request Nov 4, 2022

Use a more recent version of the mail gem to have the corect dependen…

52bd14e

…cies * See mikel/mail#1472 (comment)

Pauloparakleto added a commit to Pauloparakleto/conference that referenced this pull request Nov 6, 2022

chore update gmefile with ruby version 3.1.2 and add net-smtp require…

f2b8442

…d false accordig to issue mikel/mail#1472

graalvmbot pushed a commit to oracle/truffleruby that referenced this pull request Nov 7, 2022

Use a more recent version of the mail gem to have the corect dependen…

c7b3dfd

…cies * See mikel/mail#1472 (comment)

chipach mentioned this pull request Nov 16, 2022

Add Rails 7.0 & Ruby 3.1 support devise-security/devise-security#404

Merged

3 tasks

matthewford mentioned this pull request Nov 19, 2022

Upgrade Ruby to 3.1 mastodon/mastodon#21061

Closed

3 tasks

mzagaja mentioned this pull request Dec 1, 2022

rc3 Issue with delayed_job #1509

Closed

j1wilmot mentioned this pull request Feb 3, 2023

Mail on MacOS Ventura 13.02 Issue #1563

Closed

john-heinnickel pushed a commit to thermofisher-jch/truffleruby that referenced this pull request Aug 16, 2023

Use a more recent version of the mail gem to have the corect dependen…

46727a3

…cies * See mikel/mail#1472 (comment)

simi mentioned this pull request Apr 21, 2024

[Bundler] RFC Proposal: “include gem as” feature rubygems/rfcs#54

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Ruby 3.1 support #1472

Add Ruby 3.1 support #1472

deivid-rodriguez commented Feb 16, 2022

eregon commented Feb 16, 2022

deivid-rodriguez commented Feb 17, 2022

wolak88 commented Mar 7, 2022

deivid-rodriguez commented Mar 7, 2022

simi commented Mar 7, 2022

eregon commented Mar 10, 2022

mikel commented Apr 19, 2022

simi commented Apr 21, 2022

deivid-rodriguez commented Apr 21, 2022

johnnyshields commented Jun 24, 2022 •

edited

Loading

ghepting commented Jul 21, 2022

ashishra0 commented Jul 27, 2022

deivid-rodriguez commented Jul 27, 2022

johnnyshields commented Oct 18, 2022

Add Ruby 3.1 support #1472

Add Ruby 3.1 support #1472

Conversation

deivid-rodriguez commented Feb 16, 2022

eregon commented Feb 16, 2022

deivid-rodriguez commented Feb 17, 2022

wolak88 commented Mar 7, 2022

deivid-rodriguez commented Mar 7, 2022

simi commented Mar 7, 2022

eregon commented Mar 10, 2022

mikel commented Apr 19, 2022

simi commented Apr 21, 2022

deivid-rodriguez commented Apr 21, 2022

johnnyshields commented Jun 24, 2022 • edited Loading

ghepting commented Jul 21, 2022

ashishra0 commented Jul 27, 2022

deivid-rodriguez commented Jul 27, 2022

johnnyshields commented Oct 18, 2022

johnnyshields commented Jun 24, 2022 •

edited

Loading