2.5.x SMTP security: prevent command injection via To/From addresses #1099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validate addresses passed as SMTP command arguments to prevent injection of other SMTP commands. Disallow line breaks and very long addresses which may cause overflows on some old SMTP servers. Ruby 2.4 Net::SMTP already disallows addresses that contain newlines. Enforce this validation in Mail to cover older Ruby versions and other SMTP implementations that don't validate input. SMTP injection whitepaper: http://www.mbsd.jp/Whitepaper/smtpi.pdf Ruby security report: https://hackerone.com/reports/137631 OSVDB entry: https://rubysec.com/advisories/mail-OSVDB-131677
jeremy
changed the title
jeremy
added a commit
that referenced
this pull request
May 9, 2017
Validate addresses passed as SMTP command arguments to prevent injection of other SMTP commands. Disallow line breaks and very long addresses which may cause overflows on some old SMTP servers. Ruby 2.4 Net::SMTP already disallows addresses that contain newlines. Enforce this validation in Mail to cover older Ruby versions and other SMTP implementations that don't validate input. SMTP injection whitepaper: http://www.mbsd.jp/Whitepaper/smtpi.pdf Ruby security report: https://hackerone.com/reports/137631 OSVDB entry: https://rubysec.com/advisories/mail-OSVDB-131677 Closes #1099
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1097 for Mail 2.5