Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/VERSION causes conflicts with other gems #566

Closed
stouset opened this issue Jun 20, 2013 · 3 comments
Closed

lib/VERSION causes conflicts with other gems #566

stouset opened this issue Jun 20, 2013 · 3 comments

Comments

@stouset
Copy link

stouset commented Jun 20, 2013

The version gem fails to work correctly when mail is installed because you have a file named lib/VERSION which Ruby preferentially attempts to load.

Please be a good Ruby citizen and keep all of your project's files under lib/mail. :)

@stouset
Copy link
Author

stouset commented Jun 27, 2013

Many thanks.

@pboling
Copy link

pboling commented Jan 3, 2014

This was fixed incorrectly. It moved VERSION out of lib into the gem root. This is a reversion to #71

/VERSION needs to go here => lib/mail/version.rb

If you create a new Gem with bundler you can see the correct way to do a version (and a few other modern standards that a many-years-old gem-like-this may have not gotten hip with yet). Please play nice with all the other people who've decided to create a gem:

~ pboling$ bundle gem mail
      create  mail/Gemfile
      create  mail/Rakefile
      create  mail/LICENSE.txt
      create  mail/README.md
      create  mail/.gitignore
      create  mail/mail.gemspec
      create  mail/lib/mail.rb
      create  mail/lib/mail/version.rb
Initializing git repo in /Users/pboling/mail

As a person who uses gem package managers other than rubygems this matters to me.

@pboling
Copy link

pboling commented Jan 3, 2014

I am not sure what else to blame but I am getting seemingly random errors with Mail's auto loading of files with modules are accessed. It has happened several times now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants