Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MRI 1.9.3-p286 and 1.9.3-p327 breaks spec #453

Closed
danielevans opened this issue Nov 14, 2012 · 1 comment
Closed

MRI 1.9.3-p286 and 1.9.3-p327 breaks spec #453

danielevans opened this issue Nov 14, 2012 · 1 comment

Comments

@danielevans
Copy link

When upgrading to MRI p286/327 the following error crops up in specs:

Failure/Error: b.should eq "日本語 [email protected], 日本語 [email protected]"

   expected: "日本語 <[email protected]>, 日本語 <[email protected]>"
        got: "日本語= <[email protected]>, 日本語= <[email protected]>"

   (compared using ==)
 # ./spec/mail/encodings_spec.rb:615:in `block (4 levels) in <top (required)>'
@mikel
Copy link
Owner

mikel commented Nov 16, 2012

Thanks, fixed in commit bb25038

@mikel mikel closed this as completed Nov 16, 2012
@voxik voxik mentioned this issue Mar 6, 2013
Closed
jeremy pushed a commit that referenced this issue May 15, 2017
@wktk @jeremy
Backport fixes for specs on Ruby 1.9.3+
2a9061c 
Avoid gems which dropped support for Ruby 1.8:
- i18n (0.7.0) requires ruby (>= 1.9.3)
- activesupport (4.0.0) requires ruby (>= 1.9.3)
- rake (11.0.1) requires ruby (>= 1.9.3)

Backport 6e12d7f to fix #453.

Backport db7c955 to fix a brittle spec.

Closes #958
jeremy pushed a commit that referenced this issue May 15, 2017
@wktk @jeremy
Backport fixes for specs on Ruby 1.9.3+
b5a2884 
Avoid gems which dropped support for Ruby 1.8:
- activesupport (4.0.0) requires ruby (>= 1.9.3)
- rake (11.0.1) requires ruby (>= 1.9.3)

Backport 6e12d7f to fix #453.

Backport db7c955 to fix a brittle spec.

References #958
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikel @danielevans