Merge pull request #15 from mikehaertl/14-fix-spaces-in-filenames

Issue #14 Fix filenames with spaces
mikehaertl · May 6, 2020 · 0013625 · 0013625
2 parents e733207 + 886734d
commit 0013625
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/src/File.php b/src/File.php
@@ -89,10 +89,11 @@ public function send($filename = null, $contentType, $inline = false)
 
         if ($filename !== null || $inline) {
             $disposition = $inline ? 'inline' : 'attachment';
+            $encodedFilename = rawurlencode($filename);
             header(
-                'Content-Disposition: ' . $disposition .
-                '; filename=' . $filename .
-                "; filename*=UTF-8''" . rawurlencode($filename)
+                "Content-Disposition: $disposition; " .
+                "filename=\"$filename\"; " .
+                "filename*=UTF-8''$encodedFilename"
             );
         }