Draft: Toml #1439
Merged
Draft: Toml #1439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @pelletier - I've got started on trying to write a decoder using your API - I'm a little confused as to how the table types work? |
mikefarah
commented
Nov 18, 2022
pkg/yqlib/decoder_toml.go
Outdated
| } | ||
|
|
||
| func (dec *tomlDecoder) createTable(tomlNode *toml.Node) (*yaml.Node, error) { | ||
| log.Debug("Table: %v", string(tomlNode.Data)) |
There was a problem hiding this comment.
here specifically - what's the toml.Node structure for the table? If you look at the test I've got in toml_test.go - I have
[owners]
blah = "X"
But I only see to get owners in the node child here 🤔
There was a problem hiding this comment.
Correct. The parser returns top level expressions. So you should have a first node for the table header, then another one for key-value.
There was a problem hiding this comment.
So in this example you need two calls to NextExpression() to parse the whole document (arguably 3 to detect that you're at the end of the document and stop).
skeet70
added a commit
to IronCoreLabs/rust-toolchain
that referenced
this pull request
Jan 31, 2023
until mikefarah/yq#1439 is done
github-actions bot
pushed a commit
to IronCoreLabs/rust-toolchain
that referenced
this pull request
Jan 31, 2023
until mikefarah/yq#1439 is done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.