Make sure to update the key when deleting array elements

mikefarah · Dec 3, 2024 · e3d2cc3 · e3d2cc3
1 parent 80310ea
commit e3d2cc3
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/pkg/yqlib/operator_delete.go b/pkg/yqlib/operator_delete.go
@@ -81,6 +81,7 @@ func deleteFromArray(node *CandidateNode, childPath interface{}) {
 		shouldDelete := fmt.Sprintf("%v", index) == fmt.Sprintf("%v", childPath)
 
 		if !shouldDelete {
+			value.Key = createScalarNode(len(newContents), fmt.Sprintf("%v", len(newContents)))
 			newContents = append(newContents, value)
 		}
 	}

diff --git a/pkg/yqlib/operator_delete_test.go b/pkg/yqlib/operator_delete_test.go
@@ -179,6 +179,15 @@ var deleteOperatorScenarios = []expressionScenario{
 			"D0, P[], (!!map)::{a: {b: {age: 12}}}\n",
 		},
 	},
+	{
+		skipDoc:     true,
+		description: "Repeatedly delete the first element of a list",
+		document:    `a: [0, 1, 2, 3]`,
+		expression:  `del(.a[0]) | del(.a[0])`,
+		expected: []string{
+			"D0, P[], (!!map)::a: [2, 3]\n",
+		},
+	},
 }
 
 func TestDeleteOperatorScenarios(t *testing.T) {