[Problem]: No active_end published when Shairport is gracefully shutdown #1647
Labels
Comments
|
Thanks for this. The missing |
|
Ha yeah it doesn't come up in normal usage. As long as active_end comes after the play_end I'll be happy. |
|
This issue has been inactive for 45 days so will be closed 7 days from now. To prevent this, please remove the "stale" label or post a comment. |
|
Not stale as far as I know. |
|
I haven’t forgotten! |
|
Hi there. An update has just been pushed to the |
|
Update -- just pushed another relevant update to the |
|
This issue has been inactive for 45 days so will be closed 7 days from now. To prevent this, please remove the "stale" label or post a comment. |
|
I tried testing this on the development docker image and still saw no active_end message when shutting down the container. Is there any reason the docker image wouldn't contain this fix? Image Logs on shutdown |
|
Thanks for the update. No reason -- it should be there, but let me check! |
|
You’re right — it’s not working yet 😬. I’ll try again. |
|
Hello again. I've tried an alternative approach that looks like it works. If you got a chance to try it, that would be appreciated. |
|
That one seemed to do this trick! Thanks |
|
This issue has been inactive for 28 days so will be closed 7 days from now. To prevent this, please remove the "stale" label or post a comment. |
|
Oops never closed this. |
mtremer
pushed a commit
to ipfire/ipfire-2.x
that referenced
this issue
Sep 3, 2024
- Update from version 4.3.2 to 4.3.4
- Update of rootfile
- Changelog is only defined for 4.3, 4.2 etc so the below changelog is for all of 4.3
Cannot determine which things were alreday fixed in 4.3.2 and earlier and which are
from 4.3.3 onwards.
4.3
**Security Updates**
* A crashing bug in NQPTP has been fixed.
* The communications protocol used between NQPTP and Shairport Sync has been
revised and made more resilient to attempted misuse.
* In Linux systems, NQPTP no longer runs as `root` -- instead it runs as the
restriced user `nqptp`, with access to ports 319 and 320 set by the installer
via the `setcap` utility.
**Enhancements**
* A new volume control profile called `dasl-tapered` has been added in which
halving the volume control setting halves the output level.
For example, moving the volume slider from full to half reduces the output
level by 10dB, which roughly corresponds with a perceived halving of the audio
volume level.
Moving the volume slider from half to a quarter reduces the output level by a
a further 10dB.
The tapering rate is slightly modified at the lower end of the range if the
device's attenuation range is restricted (less than about 55dB).
To activate the `dasl-tapered` profile, set the `volume_control_profile` to
`"dasl_tapered"` in the configuration file and restart Shairport Sync.
Many thanks to David Leibovic, aka [dasl-](https://github.com/dasl-), for this.
* On graceful shutdown, an `active_end` signal should now be generated if the
system was in the active state. Addresses issue
[#1647](mikebrady/shairport-sync#1647). Thanks to
[Tucker Kern](https://github.com/mill1000) for raising the issue.
**Bug Fixes**
* Fixed a bug that causes the Docker image to crash occasionally when OwnTone
interrupted an existing iOS session. Thanks to
[aaronk6](https://github.com/aaronk6) for the report.
* Fixed a cross-compliation error caused by not looking for the correct version
of the `ar` tool. The fix was to substitute the correct version during the
`autoreconf` phase. Thanks to
[sternenseemann](https://github.com/sternenseemann) for raising the
[issue](mikebrady/shairport-sync#1705) and the
[PR](mikebrady/shairport-sync#1706) containing the fix.
* Updated the mDNS strings for the Classic AirPlay feature of AP2, so that it
does not appear to provide MFi authentication. Addresses
[this discussion](mikebrady/shairport-sync#1691).
* Always uses a revision number of 1 when looking for status updates on the DACP
remote control port. This follows a suggestion in
[Issue #1658](mikebrady/shairport-sync#1658). Thanks
to [ejurgensen](https://github.com/ejurgensen), as ever, for the report and
the suggested fix.
* Fixed a `statistics` bug (the minimum buffer size was incorrectly logged) and
also tidy up the statistics logging interval logic for resetting min and max
counters.
* Added an important missing format string argument to a call in the Jack Audio
backend. Many thanks to [michieldwitte] for their
[PR](mikebrady/shairport-sync#1693).
**Maintenance**
* Stopped using a deprecated FFmpeg data structure reference.
* Stopped using deprecated OpenSSL calls. Thanks to [yubiuser] for their
[PR](mikebrady/shairport-sync#1684) -- which did some
of the updating -- and for their guidance.
* Run workflow-based tests on PRs automatically. Thanks to [yubiuser]
for their [PR](mikebrady/shairport-sync#1687).
Signed-off-by: Adolf Belka <[email protected]>
Signed-off-by: Michael Tremer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What happened?
When Shairport Sync is shutdown gracefully it publishes a
play_endmessage via MQTT. Instead I would expect anactive_endmessage to be published as a shutdown is more like termination of an session than the stopping of a track.Relevant log output
Configuration Information.
How did you install Shairport Sync?
Built from source
Check previous issues
The text was updated successfully, but these errors were encountered: