compile error (--with-airplay-2)

[b247]

Hi, I try to compile shairport-sync (https://github.com/mikebrady/shairport-sync/blob/development/BUILDFORAP2.md) on a debian10 arm powered device (osmc on a rpi3) but got this during the make process (make -j)
rtsp.c: In function ‘handle_get_info’: rtsp.c:1510:34: error: ‘plists_get_info_response_xml’ undeclared (first use in this function); did you mean ‘pair_verify_response2’? plist_from_xml((const char *)plists_get_info_response_xml, plists_get_info_response_xml_len, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ pair_verify_response2 rtsp.c:1510:34: note: each undeclared identifier is reported only once for each function it appears in rtsp.c:1510:64: error: ‘plists_get_info_response_xml_len’ undeclared (first use in this function) plist_from_xml((const char *)plists_get_info_response_xml, plists_get_info_response_xml_len, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

[mikebrady]

Thanks for the report. Is libplist installed? What version it it? It must be 2.0.0 or later.

[b247]

Hi, libplist-dev is already the newest version (2.0.1~git20190104.3f96731-1) libplist3 is already the newest version (2.0.1~git20190104.3f96731-1) libplist++-dev is already the newest version (2.0.1~git20190104.3f96731-1)

…

On 20 Nov 2021, at 15:43, Mike Brady ***@***.***> wrote: libplist

[mikebrady]

Thanks. Could you post the ./configure options you used, please?

[b247]

./configure --sysconfdir=/etc --with-alsa --with-soxr --with-avahi --with-ssl=openssl --with-systemd --with-airplay-2

…

Sent from my iPhone

On 20 Nov 2021, at 19:30, Mike Brady ***@***.***> wrote:  Thanks. Could you post the ./configure options you used, please? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[mikebrady]

Thanks. I tried to get started with OSMC on a Pi 3 from the command line and couldn't even ssh into it -- the Mac ssh client hung up after entering the password.

[mikebrady]

So, I spun up a minimal arm64 based Debian 11 and built nqptp and Shairport Sync without any difficulties. Therefore, I think it must be something specific to the OSMC image -- I suggest you talk to the OSMC guys.

[b247]

Thank You Mike. I am using OSMC 2020.11-1 (debian 10 buster - armhf [32bit] ) version on a RPI 3 armv7l CPU. Could be a problem that I am using a 32bit OS (debian 10/11 armhf)?

[mikebrady]

I'm afraid I am unable to test for that. A 32-bit OS shouldn't be a problem per se. After all, the Raspberry Pi OS is still 32-bit. (FWIW, Shairport Sync also builds on an arm64 based Debian 10.)

[b247]

Never mind

…

On 21.11.2021 14:02, Mike Brady wrote: I'm afraid I am unable to test for that. A 32-bit OS shouldn't be a problem /per se/. After all, the Raspberry Pi OS is still 32-bit. (FWIW, Shairport Sync also builds on an |arm64| based Debian 10.) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1341 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGLTZXWIIBBLV5XH74ABRFTUNDNWBANCNFSM5IN3XRNA>.

[Lorilandly]

Hi, I found out that this problem is because the generated plist_xml_strings.h is empty. This is caused by a command in the makefile not executed. One can encounter this issue if xxd is not installed on the system the first time shairport-sync is compiled, stops on line 1605 in the makefile, resulted in an empty plist_xml_strings.h. Compile again after xxd is installed by the user, the makefile sees that plist_xml_strings.h already exists and will not attempt to add the rest of the code to it. Thus, compilation breaks. You can solve the problem if you run manually the line xxd -i plists/get_info_response.xml >> plist_xml_strings.h before building.

[b247]

It worked, thank you

…

On 8 Dec 2021, at 04:23, Lorilandly ***@***.***> wrote:  Hi, I found out that this problem is because the generated plist_xml_strings.h is empty. This is caused by a command in the makefile not executed. One can encounter this issue if xxd is not installed on the system the first time shairport-sync is compiled, stops on line 1605 in the makefile, resulted in an empty plist_xml_strings.h. Compile again after xxd is installed by the user, the makefile sees that plist_xml_strings.h already exists and will not attempt to add the rest of the code to it. Thus, compilation breaks. You can solve the problem if you run manually the line xxd -i plists/get_info_response.xml >> plist_xml_strings.h before building. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[mikebrady]

Hi, I found out that this problem is because the generated plist_xml_strings.h is empty. This is caused by a command in the makefile not executed. One can encounter this issue if xxd is not installed on the system the first time shairport-sync is compiled, stops on line 1605 in the makefile, resulted in an empty plist_xml_strings.h. Compile again after xxd is installed by the user, the makefile sees that plist_xml_strings.h already exists and will not attempt to add the rest of the code to it. Thus, compilation breaks. You can solve the problem if you run manually the line xxd -i plists/get_info_response.xml >> plist_xml_strings.h before building.

Many thanks for finding this and for providing a PR to fix it!

[github-actions]

This issue has been inactive for 45 days so will be closed 7 days from now. To prevent this, please remove the "stale" label or post a comment.

[anatol]

I hit the same issue at Arch Linux.

It would be nice if the build system failed early in case xxd is absent.

[duhow]

Same here, just faced this issue.. @mikebrady ?

[mikebrady]

Thanks for the update. Is there something missing from the build guide?

[duhow]

Ideally, if xxd program is missing, the Makefile build command should warn the user of this.
I'm currently building shairport in Docker image builder, and needed to install this application due to Airplay2.

[mikebrady]

That should be fixed now in the development branch. Thanks for the reminder. If you got a chance to check it, that would be very useful.