dependency problem; unable to get test environment working

[jccartwright]

• System Information

  • Browser type and version
    Chrome 71.0.3578.98
  • OS type and version
    MacOS 10.13.06
  • WINDOWS: be sure to indicate which terminal you're using -- (i.e., cmd.exe, powershell, git- bash, cygwin, Ubuntu via windows subsystem for linux, etc...)
  • Node version
    10.7.0
  • Any error messages that may be in the console where you ran npm start
  • Any error messages in the JS console

• Describe the bug

• To Reproduce
  Steps to reproduce the behavior:

1. git clone https://github.com/mike-works/typescript-fundamentals tscript
2. cd tscript
3. yarn
4. See error:
   yarn install v1.12.3
   [1/4] 🔍 Resolving packages...
   [2/4] 🚚 Fetching packages...
   error https://registry.yarnpkg.com/har-validator/-/har-validator-5.1.2.tgz: Extracting tar content of undefined failed, the file appears to be corrupt: "Unexpected end of data"
   info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

• Expected behavior
  yarn to complete successfully.

• Screenshots (optional)
  If applicable, add screenshots to help explain your problem.

• Additional context (optional)
  Add any other context about the problem here.

[the-other-nick-wilson]

I'm not sure if this is the best approach, but based on what I found here, I just updated the relevant section in the yarn.lock file to 5.1.3.

So change this:

har-validator@~5.1.0:
  version "5.1.2"
  resolved "https://registry.yarnpkg.com/har-validator/-/har-validator-5.1.2.tgz#a3891924f815c88e41c7f31112079cfef5e129e5"
  integrity sha512-OFxb5MZXCUMx43X7O8LK4FKggEQx6yC5QPmOcBnYbJ9UjxEcMcrMbaR0af5HZpqeFopw2GwQRQi34ZXI7YLM5w==
  dependencies:
    ajv "^6.5.5"
    har-schema "^2.0.0"

To this:

har-validator@~5.1.3:
  version "5.1.3"
  resolved "https://registry.yarnpkg.com/har-validator/-/har-validator-5.1.2.tgz#a3891924f815c88e41c7f31112079cfef5e129e5"
  integrity sha512-OFxb5MZXCUMx43X7O8LK4FKggEQx6yC5QPmOcBnYbJ9UjxEcMcrMbaR0af5HZpqeFopw2GwQRQi34ZXI7YLM5w==
  dependencies:
    ajv "^6.5.5"
    har-schema "^2.0.0"

And try the yarn install command again and it should work. Basically it appears the har-validator package was tagged under the wrong version.

What I don't know is if I was supposed to update both of those versions, or just the top one. It would be nice to get some confirmation here.

[jccartwright]

thanks for the prompt response. modifying the version does indeed seem to allow yarn to install dependencies correctly.

However, I'm now wondering if the test script is working as expected. For example
cd exercises; npm test color-functions

does not run the tests for "color-functions". It looks to me as if the scripts/test/index.sh should contain
./node_modules/.bin/jest --no-cache --watch $1
rather than
./node_modules/.bin/jest --no-cache --watch $2

[the-other-nick-wilson]

Hmm, I don't think you need to cd into the exercises directory. Did you try npm test color-functions from the base directory? Do you get an error when trying to run it?

[jccartwright]

Yes, the behavior is the same from the base directory. It appears to me the problem is the positional parameter in the script, i.e. npm test junk color-functions works OK as does modifying test/scripts/index.sh to contain: ./node_modules/.bin/jest --no-cache --watch $1

…

On Jan 8, 2019, at 11:03 AM, Nick Wilson ***@***.***> wrote: Hmm, I don't think you need to cd into the exercises directory. Did you try npm test color-functions from the base directory? Do you get an error when trying to run it? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#184 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA4CBnvF4YnxwtB9Lta_oGx08XA63vqJks5vBN1kgaJpZM4ZyIMd>.

[the-other-nick-wilson]

Weird, I totally see what you mean, but mine works just fine with:

npm test color-functions

Even though my index.sh is:

#!/bin/bash ./node_modules/.bin/jest --no-cache --watch $2

I tried:

npm test junk color-functions

And that still works too.

[mike-north]

I just updated the lock file, with an upgrade to node-sass.

Before

yarn why har-validator

=> Found "[email protected]"
info Reasons this module exists
   - "node-sass#request" depends on it
   - Hoisted from "node-sass#request#har-validator"

After

yarn why har-validator

=> Found "[email protected]"
info Reasons this module exists
   - "node-sass#request" depends on it
   - Hoisted from "node-sass#request#har-validator"

[mike-north]

🎉 This issue has been resolved in version 1.0.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀