Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed heroku build error #92

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixed heroku build error #92

wants to merge 1 commit into from

Conversation

sevskii111
Copy link

No description provided.

@ghost
Copy link

ghost commented Jan 24, 2020

There were the following issues with this Pull Request

  • Commit: b30f298
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.

🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@nielsboecker
Copy link

I can confirm that this fix works. Without specifying engines, the default node environment on Heroku fails to build the app.

I assume that this should also resolve #5 and #101.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sevskii111 @nielsboecker