Added faster intersection with benchmark #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-engel
reviewed
Jul 31, 2023
src/lib.rs
Outdated
| /// | ||
| /// let common_languages = intersection_fast("en-US, en-GB;q=0.5", &["de", "en-GB", "en-US"]); | ||
| /// ``` | ||
| pub fn intersection_fast(raw_languages: &str, supported_languages: &[&str]) -> Vec<String> { |
There was a problem hiding this comment.
I wonder if intersection_ordered might be a better name? That's the important part, and I think adding ordered to the name would cause people to pay more attention to the docs than fast would
There was a problem hiding this comment.
Indeed, better name it after the method than the result. Also the quality member in the struct could be compacted to a f32 instead of a f64, don't you think?
… can be found faster if a binary sorted list of available languages is applied. A small testbench is added with 200+ languages to demonstrate the improvement. Also float quality is reduced from f64 to f32, as practically only 1 or 2 decimal digits are used.
peter-scholtens
force-pushed
the
patch-1
branch
from
2c5287d to
55e4a23
Compare
|
@peter-scholtens sorry for the delay, yes I think that's fine |
|
I solved the problem by moving the benches to a special benches directory. No need to import another crate. See solution as provided in #12. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The languages can be found faster with binary sort in the list of available languages if we assume that they are sorted in alphabetical order. With 200+ languages this improves intersection with 25%.