Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable lua-language-server checkTableShape by default #384

Merged
merged 1 commit into from
Aug 17, 2024

Conversation

mikavilpas
Copy link
Owner

It was released yesterday, but was toggled off by default.
The example in the pull request works nicely.

- pull request
  - LuaLS/lua-language-server#2768
- comment saying why it was toggled off
  - LuaLS/lua-language-server#2768 (comment)
- changelog with a little more info
  - https://github.com/LuaLS/lua-language-server/blob/d702a55715df19a219e963da496e6fb76db0aacd/changelog.md?plain=1#L8
@mikavilpas
Copy link
Owner Author

It works in ci too.

lua/yazi/testfail.lua:13:5:13:6: WARN Cannot assign table to parameter Foo. [param-type-mismatch]

@mikavilpas mikavilpas force-pushed the enable-check-table-shape branch from e79ded3 to bf94dc2 Compare August 17, 2024 05:50
@mikavilpas mikavilpas enabled auto-merge (squash) August 17, 2024 05:50
@mikavilpas mikavilpas merged commit 6940975 into main Aug 17, 2024
28 checks passed
@mikavilpas mikavilpas deleted the enable-check-table-shape branch August 17, 2024 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant