[SIM111] adding regression test for yoda condition of litteral vs obj…

…ect's constant follow-up of fix added in astral-sh#9164 Signed-off-by: Mikael Arguedas <[email protected]>
mikaelarguedas · Dec 28, 2023 · f154144 · f154144
1 parent 8708619
commit f154144
Show file tree

Hide file tree

Showing 3 changed files with 33 additions and 0 deletions.
diff --git a/crates/ruff_linter/resources/test/fixtures/flake8_simplify/SIM300.py b/crates/ruff_linter/resources/test/fixtures/flake8_simplify/SIM300.py
@@ -40,3 +40,4 @@
 SECONDS_IN_DAY == 60 * 60 * 24 # Error in 0.1.8
 SomeClass().settings.SOME_CONSTANT_VALUE > (60 * 60) # Error in 0.1.8
 {"non-empty-dict": "is-ok"} == DummyHandler.CONFIG
+11 == SomeClass().settings.SOME_CONSTANT_VALUE
diff --git a/...ake8_simplify/snapshots/ruff_linter__rules__flake8_simplify__tests__SIM300_SIM300.py.snap b/...ake8_simplify/snapshots/ruff_linter__rules__flake8_simplify__tests__SIM300_SIM300.py.snap
@@ -351,4 +351,20 @@ SIM300.py:24:1: SIM300 [*] Yoda conditions are discouraged, use `{} == DummyHand
 26 26 | # OK
 27 27 | compare == "yoda"
 
+SIM300.py:43:1: SIM300 [*] Yoda conditions are discouraged, use `SomeClass().settings.SOME_CONSTANT_VALUE == 11` instead
+   |
+41 | SomeClass().settings.SOME_CONSTANT_VALUE > (60 * 60) # Error in 0.1.8
+42 | {"non-empty-dict": "is-ok"} == DummyHandler.CONFIG
+43 | 11 == SomeClass().settings.SOME_CONSTANT_VALUE
+   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ SIM300
+   |
+   = help: Replace Yoda condition with `SomeClass().settings.SOME_CONSTANT_VALUE == 11`
+
+ℹ Safe fix
+40 40 | SECONDS_IN_DAY == 60 * 60 * 24 # Error in 0.1.8
+41 41 | SomeClass().settings.SOME_CONSTANT_VALUE > (60 * 60) # Error in 0.1.8
+42 42 | {"non-empty-dict": "is-ok"} == DummyHandler.CONFIG
+43    |-11 == SomeClass().settings.SOME_CONSTANT_VALUE
+   43 |+SomeClass().settings.SOME_CONSTANT_VALUE == 11
+
 
diff --git a/...lify/snapshots/ruff_linter__rules__flake8_simplify__tests__preview__SIM300_SIM300.py.snap b/...lify/snapshots/ruff_linter__rules__flake8_simplify__tests__preview__SIM300_SIM300.py.snap
@@ -351,4 +351,20 @@ SIM300.py:20:1: SIM300 [*] Yoda conditions are discouraged, use `DummyHandler.CO
 22 22 | # Errors in stable
 23 23 | UPPER_LIST == ['upper']
 
+SIM300.py:43:1: SIM300 [*] Yoda conditions are discouraged, use `SomeClass().settings.SOME_CONSTANT_VALUE == 11` instead
+   |
+41 | SomeClass().settings.SOME_CONSTANT_VALUE > (60 * 60) # Error in 0.1.8
+42 | {"non-empty-dict": "is-ok"} == DummyHandler.CONFIG
+43 | 11 == SomeClass().settings.SOME_CONSTANT_VALUE
+   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ SIM300
+   |
+   = help: Replace Yoda condition with `SomeClass().settings.SOME_CONSTANT_VALUE == 11`
+
+ℹ Safe fix
+40 40 | SECONDS_IN_DAY == 60 * 60 * 24 # Error in 0.1.8
+41 41 | SomeClass().settings.SOME_CONSTANT_VALUE > (60 * 60) # Error in 0.1.8
+42 42 | {"non-empty-dict": "is-ok"} == DummyHandler.CONFIG
+43    |-11 == SomeClass().settings.SOME_CONSTANT_VALUE
+   43 |+SomeClass().settings.SOME_CONSTANT_VALUE == 11
+