Skip to content

Commit

Permalink
More tinkering
Browse files Browse the repository at this point in the history
  • Loading branch information
mihnita committed Sep 29, 2024
1 parent bebc551 commit 0cd8b68
Show file tree
Hide file tree
Showing 3 changed files with 31 additions and 12 deletions.
5 changes: 4 additions & 1 deletion .github/workflows/release-icu4c-fedora.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@ name: Release - ICU4C artifacts on Fedora
on:
workflow_dispatch:
inputs:
skipTests:
description: 'Skip running the tests.'
type: boolean
default: false
gitTag:
# TODO: make this mandatory and validate that it is in a release* branch and looks like
# For now we don't do it so that we can test.
Expand Down Expand Up @@ -39,7 +43,6 @@ jobs:
make -j8
# TODO: make check to make sure that what we publish works
# make check
make DESTDIR=/tmp/icu releaseDist
make DESTDIR=$GITHUB_WORKSPACE/releaseDist/icu releaseDist
popd
Expand Down
30 changes: 19 additions & 11 deletions .github/workflows/release-icu4c-ubuntu.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@ name: Release - ICU4C artifacts on Ubuntu
on:
workflow_dispatch:
inputs:
skipTests:
description: 'Skip running the tests.'
type: boolean
default: false
gitTag:
# TODO: make this mandatory and validate that it is in a release* branch and looks like
# For now we don't do it so that we can test.
Expand Down Expand Up @@ -33,25 +37,29 @@ jobs:
- name: Build release ICU4C
run: |
pushd icu4c/source
echo "==== runConfigureICU ===="
./runConfigureICU Linux/gcc
echo "==== make ===="
make -j8
# TODO: make check to make sure that what we publish works
# make check
echo "==== make dist ===="
make dist
echo "==== make releaseDist ===="
make DESTDIR=$GITHUB_WORKSPACE/releaseDist/icu releaseDist
echo "=========================="
#tmp ./runConfigureICU Linux/gcc
# make -j8
echo SPY on SKIP_TESTS = $SKIP_TESTS
if [ $SKIP_TESTS = "true" ]; then
echo SKIPPING TESTS
else
#tmp make check
echo RUNNING TESTS
fi
#tmp make dist
#tmp make DESTDIR=$GITHUB_WORKSPACE/releaseDist/icu releaseDist
popd
env:
SKIP_TESTS: ${{ inputs.skipTests }}
GIT_TAG: ${{ inputs.gitTag }}

- name: Collect artifacts in one folder
run: |
# Get the OS version in VERSION_ID
source /etc/os-release
# Get the ICU version in artifact_version
source icu4j/releases_tools/shared.sh
# Convert 76.1 to 76_1
underscore_version=$(echo $artifact_version | sed 's/\./_/g')
pushd releaseDist
tar -czf icu4c-${underscore_version}-Ubuntu${VERSION_ID}-x64.tgz icu
Expand Down
8 changes: 8 additions & 0 deletions .github/workflows/release-icu4j-maven.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,14 @@ on:
# https://docs.github.com/en/actions/managing-workflow-runs/manually-running-a-workflow
workflow_dispatch:
inputs:
skipTests:
description: 'Skip running the tests.'
type: boolean
default: false
mavenDeploy:
description: 'Deploy to Sonatype. It will do it to a local folder.'
type: boolean
default: false
gitTag:
# TODO: make this mandatory and validate that it is in a release* branch and looks like
# 'release-\d+.\d+ or something like that.
Expand Down

0 comments on commit 0cd8b68

Please sign in to comment.