-
-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sanic HTTPResponse parameter has been removed #213
Comments
happy to make a PR if you'd like, just let me know if you have something in mind for backward compatibility |
Maybe I should have looked around a bit deeper - completely missed #207 🤦 |
jdraymon
added a commit
to jdraymon/python-engineio
that referenced
this issue
Jan 30, 2021
Switch between sanic HTTPResponse instantiation keyword arguments based on the results of `inspect` Resolves: miguelgrinberg#213
jdraymon
added a commit
to jdraymon/python-engineio
that referenced
this issue
Jan 30, 2021
Switch between sanic HTTPResponse instantiation keyword arguments based on the results of `inspect` Resolves: miguelgrinberg#213
jdraymon
added a commit
to jdraymon/python-engineio
that referenced
this issue
Jan 30, 2021
Switch between sanic HTTPResponse instantiation keyword arguments based on the results of `inspect` Resolves: miguelgrinberg#213
jdraymon
added a commit
to jdraymon/python-engineio
that referenced
this issue
Jan 30, 2021
Switch between sanic HTTPResponse instantiation keyword arguments based on the results of `inspect` Resolves: miguelgrinberg#213
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The parameter
body_bytes
for Sanic's HTTPResponse was deprecated with this PRsanic-org/sanic#1739 (part of 20.6.1)
And removed entirely in:
sanic-org/sanic#1981 (part of 20.12.1)
The new preferred parameter name appears to be
body
, but presently using newer versions of sanic results in an unexpected kwarg TypeError.The text was updated successfully, but these errors were encountered: