Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanic HTTPResponse parameter has been removed #213

Closed
jdraymon opened this issue Jan 29, 2021 · 2 comments
Closed

Sanic HTTPResponse parameter has been removed #213

jdraymon opened this issue Jan 29, 2021 · 2 comments

Comments

@jdraymon
Copy link

The parameter body_bytes for Sanic's HTTPResponse was deprecated with this PR
sanic-org/sanic#1739 (part of 20.6.1)

And removed entirely in:
sanic-org/sanic#1981 (part of 20.12.1)

The new preferred parameter name appears to be body, but presently using newer versions of sanic results in an unexpected kwarg TypeError.

@jdraymon
Copy link
Author

happy to make a PR if you'd like, just let me know if you have something in mind for backward compatibility

@jdraymon
Copy link
Author

Maybe I should have looked around a bit deeper - completely missed #207 🤦

jdraymon added a commit to jdraymon/python-engineio that referenced this issue Jan 30, 2021
Switch between sanic HTTPResponse instantiation keyword arguments based
on the results of `inspect`

Resolves: miguelgrinberg#213
jdraymon added a commit to jdraymon/python-engineio that referenced this issue Jan 30, 2021
Switch between sanic HTTPResponse instantiation keyword arguments based
on the results of `inspect`

Resolves: miguelgrinberg#213
jdraymon added a commit to jdraymon/python-engineio that referenced this issue Jan 30, 2021
Switch between sanic HTTPResponse instantiation keyword arguments based
on the results of `inspect`

Resolves: miguelgrinberg#213
jdraymon added a commit to jdraymon/python-engineio that referenced this issue Jan 30, 2021
Switch between sanic HTTPResponse instantiation keyword arguments based
on the results of `inspect`

Resolves: miguelgrinberg#213
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants