-
-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update components to be on par with angular material v1 #249
Comments
Does updating also mean including closure actions? |
@SirZach Sure! Just added "use new ember features when applicable (e.g closure actions)" as a part of the update process. |
@miguelcobain if you can describe how you would best like to see that implemented, I'll give a stab at a PR. I know you like the ember-actions(?) addon that you're using ember-leaflet. |
@SirZach A PR that uses ember-actions will be accepted, of course. People could use them immediately. However, feels easier if that was to be made part of the update process. |
Will this lead to breaking changes? If so can we make an effort to document them with a clear migration path? |
@joukevandermaas It may lead to breaking changes or may not. I'm not into angular 1 changes yet. |
@miguelcobain do you want to work from the 1.0 branch or the 1.0.1 branch that was released a couple of days ago? |
Currently working for 1.0.0 release. Shouldn't be hard to take it to A sáb, 19/12/2015, 23:28, James Dixon [email protected] escreveu:
|
thanks, @miguelcobain. before I start, anything special when bringing over the style sheets -- literally just a copy/paste or is there anything else that needs to be done to prep for EP? |
One of the main features of ember-paper 1.0 will be the automatic pulling A dom, 20/12/2015, 00:23, James Dixon [email protected] escreveu:
|
Awesome work! I won't be able to work on this until the weekend, but I'll take a look then. 👍 |
@miguelcobain how about converting components into pod structure, hbs next to the components js |
@xomaczar That would be awesome. Is that possible in addons? |
Yes, just do |
pod discussion at #82 |
Also, can 1.0 make use of contextual components (2.3+)? |
@knownasilya Yes, for a couple of reasons:
Nevertheless, I think we should discuss the use of contextual components on a per component basis. |
I think we should start using |
@jaichandra I'm really glad that you were considering using Ember Paper in your organization. I wanted to follow up and see how things were going with that effort? I had to take the same considerations into account before adopting it at my organization. Are there any major blockers that you've run into so far? Ember Paper has been gaining a lot of momentum, and community contributions are still welcome to help get |
@miguelcobain are there any plans to support a subheader? https://material.angularjs.org/latest/demo/subheader |
@chbonser We can hide it behind an officially maintained component, but I do this for now:
|
But for anything more than static styles, we'll have to see about tying that into a pattern for "sticky" items. |
Do we want to add Chips to this list? #267 it has been rebased and will probably pass tests if the PR is reopened. The only current issue with that PR at the moment is that Autocomplete seems to be broken. It's broken on the main Autocomplete demo page as well so it's not something silly I'm doing 😂 |
Quite close to milestone and things looking quite solid. |
@v3ss0n there are already alpha releases. :) |
how to get them on CLI ? |
i mean 0.2.14 is still 0.2x release right? not after new 1.0x branch merged , right? |
@v3ss0n Correct. Follow instructions on website to install latest version (the main website runs on alpha). |
thanks gonna try now. |
@miguelcobain it doesn't look like |
@steven-ferguson just use master version right now. it is much improved and stable |
Can you do something similar for the latest release? Create a milestone document what needs to be done to reach 1.0.0 and we can all pitch in? |
@anthonycollini not sure I understand. This is the document to reach 1.0. we didn't reach it yet (although we're close). |
@miguelcobain Can you update the reference in "Tabs (@mellatone in #314)" in the top comment, to point to #578 ? |
@saerdnaer done. thanks. |
Just wanted to check in here - read most of this thread, but see no activity here in the last several months - totally cool, everyone has lives! :-) Just wanted to ask how the 1.0.0 release is coming, and how everyone feels - is it close? This-year-close? Next year perhaps? Just checking, no worries, just curious. Great work everyone! |
@josiahbryan It might be closer than you think. No one's commenting in this thread but the OP is being updated.
I consider the current release to be fully stable and am using it in production and I know many others are too. #738 (comment) |
Wow, good job all! Thanks for the input, good to hear! I'll seriously consider it then for my next project for sure. Quick question, since you and others are using it in prod quite successfully - does it play nice with bootstrap then? Or is bootstrap and this project (and styles) mutually exclusive? |
Hmm i guess they are both class based so you might be able to use them both. Personally I'd just use one though since they accomplish the same task. Using 1 means a more cohesive style for your app and doesn't force your users to download 2 separate styling frameworks. There's things like this out there too https://mdbootstrap.com/material-design-for-bootstrap/ |
Yeah, tried m-d-for-bs but ...yeah...felt very poorly done in practice and left me gun-shy of material design in general....that is, until I started my latest project, based on bootstrap, and found myself constantly trying to emulate the navbars, buttons, side menus, input fields, et al - all manually, through my own CSS modifications on top of bootstrap. Then I realized (just today), that even though I started with a bootstrap base, I was constantly moving closer and closer to a material look and feel for it since I kept trying to emulate native android apps. At this point, I'm too invested and too close to beta launch of Sept 1 (per management) on the project to switch to ember-paper, but the next project we start here, I absolutely will try ember-paper with at least one of the betas, even if not full 1.0.0 yet. Thanks for the space to rant, sorry to clutter the thread. All that is to say, good work guys, and this looks like an awesome project. Stoked to get my hands dirty with your {{paper}} components in my hbs in my next project. Cheers! |
@jaichandra we are using it in production for a mobile + Desktop app medical consultation chat platform for medical consultation. We have it running : more than 10K monthly active users.Not in english tho. |
What stylesheets does 1.0.0 use? Are they the latest angular stylesheets (https://material.angular.io/)? |
@anthonycollini correct. |
Angular material has reached v1.0.0.
It is now a good time for us to update ember-paper to be on par with angular material.
Component List
Components should be updated using the automatically-imported Angular Material stylesheets. See
Angular Material v1.0.6 for reference: https://github.com/angular/material/tree/v1.0.6
How to get started
For each component in the above list, one should:
tests/
folder. It's a regular ember application. Don't waste too much time on docs for now. We'll update the docs later using angular material docs for inspiration, where applicable.Example commit (paper-progress-circular): 1a9b641
Try to follow the same style.
Current work for ember-paper v1 is being done at master Reference in issues to branch
wip/v1.0.0
now refer tomaster
as the wip branch was merged into master.FAQ
See this comment for some more info: FAQ
The text was updated successfully, but these errors were encountered: