Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not disable cancel button if disabled prop is true #561

Merged
merged 1 commit into from
Dec 16, 2022
Merged

Do not disable cancel button if disabled prop is true #561

merged 1 commit into from
Dec 16, 2022

Conversation

cry-stal-lee
Copy link
Contributor

@cry-stal-lee cry-stal-lee commented Dec 16, 2022 •
edited
Loading

Description

  • The disabled prop should probably only affect the submit button
  • I think the only time we'd really want to disable the cancel button is when the form is saving

JIRA: https://thatsmighty.atlassian.net/browse/PROD-1533

QA: https://mighty.testpad.com/script/168#49// (0039-0043)

Screenshot 2022-12-16 at 9 49 42 AM

@cry-stal-lee cry-stal-lee force-pushed the prod-1533/make-cancel-button-enabled-if-information-is-missing branch from bc52e50 to 90a2573 Compare December 16, 2022 00:30
@cry-stal-lee cry-stal-lee changed the title Only disable cancel button if form is saving Do not disable cancel button if disabled prop is true Dec 16, 2022
@cry-stal-lee cry-stal-lee merged commit 4f287b0 into master Dec 16, 2022
@cry-stal-lee cry-stal-lee deleted the prod-1533/make-cancel-button-enabled-if-information-is-missing branch December 16, 2022 16:37
@cry-stal-lee cry-stal-lee restored the prod-1533/make-cancel-button-enabled-if-information-is-missing branch December 16, 2022 17:11
@cry-stal-lee cry-stal-lee deleted the prod-1533/make-cancel-button-enabled-if-information-is-missing branch December 16, 2022 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mumumumu mumumumu mumumumu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cry-stal-lee @mumumumu