Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document and test std/sugar, std/source, plus fixes #993

Merged
merged 7 commits into from
Oct 7, 2023
Merged

Document and test std/sugar, std/source, plus fixes #993

merged 7 commits into from
Oct 7, 2023

Conversation

fare
Copy link
Collaborator

@fare fare commented Oct 7, 2023

No description provided.

@netlify
Copy link

netlify bot commented Oct 7, 2023

Deploy Preview for elastic-ritchie-8f47f9 ready!

Name Link
🔨 Latest commit 7c6d90e
🔍 Latest deploy log https://app.netlify.com/sites/elastic-ritchie-8f47f9/deploys/65212e6c02f84700085dd2a8
😎 Deploy Preview https://deploy-preview-993--elastic-ritchie-8f47f9.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

``` Scheme
> (import :std/error)
> (def (unbound-runtime-exception? e)
(match e ((RuntimeException exception: (? unbound-global-exception?)) #t)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just unbound-global-exception? Does this for you.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what you mean...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the runtime already wraps the gambit exception predicates to unwrap them from RuntimeException.

@@ -97,27 +171,88 @@ you thus have to pass the receiver as first argument to the method.
The advantage over `using` is that there is no implicit allocation for
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stale, there is no advantage over using.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I remove altogether from sugar? What exactly do I remove or keep?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, remove.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there used to be an older using macro, got removed with the intro of real using.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point, I'll let this PR get in, and you can remove the code and docs and tests.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link
Collaborator

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vyzo vyzo enabled auto-merge (squash) October 7, 2023 10:13
@vyzo vyzo merged commit 32b454c into master Oct 7, 2023
@vyzo vyzo deleted the sugar branch October 7, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants