Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miscellaneous fixes #729

Merged
merged 4 commits into from
Jul 18, 2023
Merged

Miscellaneous fixes #729

merged 4 commits into from
Jul 18, 2023

Conversation

vyzo
Copy link
Collaborator

@vyzo vyzo commented Jul 18, 2023

Cherry picked from #728.
Summary:

  • fix issues with the syntax quoting in mixin interface methods; syntax-local-introduce is appropiate
  • don't generate dynamic method bindings for interfaces, it defeats the purpose.
  • fix a typo in :gerbil/gambit/fixnum
  • improve check failure reporting in :std/test to also display the expected value.

vyzo added 4 commits July 18, 2023 08:54
@vyzo
simplify interface macro internals
a5c973c 
- the syntax quote is harmful, bombs in the interpreter; it is also
  probably unnecessary, will cross that bridge when we get there.
- no need to bind methods in the interface type, dynamic dispatch is
  against the spirit of interfaces
@vyzo
syntax local introduce methods that come from mixins
455a41e 
that should help with symbol visibility.
@vyzo
fix typo in :gerbil/gambit/fixnum
742f546
@vyzo
std/test: display expected values on failed checks.
2d29743
@vyzo vyzo requested review from fare and ober July 18, 2023 06:01
@vyzo vyzo merged commit 981110a into master Jul 18, 2023
@vyzo vyzo deleted the misc-fixes branch July 18, 2023 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fare fare Awaiting requested review from fare

@ober ober Awaiting requested review from ober

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vyzo