Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 404s #722

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Fix 404s #722

merged 1 commit into from
Jul 12, 2023

Conversation

ober
Copy link
Collaborator

@ober ober commented Jul 12, 2023

No description provided.

vyzo
vyzo reviewed Jul 12, 2023
View reviewed changes
Copy link
Collaborator

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets keep prs focused, can we remove the dockerfille changes?

They are completely unrelated, so we should do a separate pr.

vyzo
vyzo reviewed Jul 12, 2023
View reviewed changes
vyzo
vyzo approved these changes Jul 12, 2023
View reviewed changes
Copy link
Collaborator

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

PS: Rebased and dropped the unrelated commits.

@vyzo vyzo merged commit 2d5c76a into master Jul 12, 2023
@vyzo vyzo deleted the fix-404s branch July 12, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyzo vyzo vyzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ober @vyzo