Fix Sad CI #715
Merged
Fix Sad CI #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, let's make it a "fix CI" pr. I will change the title, but the CI checks still failing. |
|
Gambit/gerbil now build on all of the branches. Failure is just on tests. |
|
Great, can we also fix the tests? |
|
I can also look at it if you want. |
|
So I fixed the crypto problems, let's see if anything else bombs. |
The whole thing was completely broken; you need to call DigestSignInit and DigestVerifyInit.
|
Did some squashing to cleanly separate commit responsibility. |
vyzo
approved these changes
Jul 7, 2023
fare
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #711
Issues resolved by this pr: