Migrate CI to GitHub Actions

[dlozeve]

Fixes #636.
Fixes #80.

There are two workflows, one using Gambit 4.9.3 and one using Gambit master. At present, Gambit master fails to compile (although it uses the exact same build commands as 4.9.3), I'll have to investigate more.

[dlozeve]

It took a while to fix caching issues, but now it should work: first run without cache, second run with cache.

Gambit master still doesn't compile, I haven't been able to find the source of the error. If someone has an idea, I'm interested! The latest Gambit CI is successful, so this one should compile correctly as well...

[vyzo]

Thank you, this is great!

[vyzo]

Let's run it to see the build failure for gambit head.

[vyzo]

ok, this looks like we might not setting up the environment correctly -- can we look at gambit's CI and see how they build there?

[dlozeve]

Actually, I can reproduce the error locally. With a fresh clone of gambit, on master:

./configure --enable-single-host
make

I get the same error as I get in the CI:

_kernel.c: In function ‘___H___kernel’:
_kernel.c:5046:44: error: ‘struct ___virtual_machine_state_struct’ has no member named ‘main_module_id’; did you mean ‘main_module_ref’?
 5046 | ___RESULT = ___VMSTATE_FROM_PSTATE(___ps)->main_module_id;
      |                                            ^~~~~~~~~~~~~~
      |                                            main_module_ref

I don't see anything in their CI config that is significantly different, so I'm not sure where we could go from here. Maybe there is something to do that isn't yet documented in the INSTALL file?

[vyzo]

Lets file an issue in gambit and ask marc. gitter might be faster.

…

On Sat, Oct 23, 2021, 17:30 Dimitri Lozeve ***@***.***> wrote: Actually, I can reproduce the error locally. With a fresh clone of gambit, on master: ./configure --enable-single-host make I get the same error as I get in the CI: _kernel.c: In function ‘___H___kernel’: _kernel.c:5046:44: error: ‘struct ___virtual_machine_state_struct’ has no member named ‘main_module_id’; did you mean ‘main_module_ref’? 5046 | ___RESULT = ___VMSTATE_FROM_PSTATE(___ps)->main_module_id; | ^~~~~~~~~~~~~~ | main_module_ref I don't see anything in their CI config <https://github.com/gambit/gambit/blob/master/.github/workflows/ci.yml#L125> that is significantly different, so I'm not sure where we could go from here. Maybe there is something to do that isn't yet documented in the INSTALL file? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#637 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAI4SSQTCCJ4KBNU2LDQSLUILBHXANCNFSM5GSDMF7A> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[vyzo]

might need make bootclean?

[dlozeve]

I fixed the issue! Turns out make bootclean is not required, Gambit correctly identifies when it needs to bootstrap. However, in the default configuration, the "checkout" GitHub Action does not fetch all branches and tags, and changing that fixed the issue. (I don't know exactly how Gambit's build process depends on other branches and tags, but they do set this explicit setting in their own CI.)

Gambit master builds fine now, but Gerbil's tests do not pass on it.

[vyzo]

Great! Dont worry about the test failure in increment, that test is faulty. We can fix it either in this pr (if you want) or a subsequent one.

[dlozeve]

As you wish!

[vyzo]

if you dont mind fixing it, lets get a green checkmark. Basically the expectation of void result from multi increment is incorrect, it is unspecified. So to fix, remove the check around the increment there -- the result is checked below.

[dlozeve]

Maybe this should also close #80?

[vyzo]

ah yes, indeed! Mind updating the description to autoclose?

[vyzo]

Thank you, this is great!