-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
std/net/request: allow attaching data to all http verbs #603
Conversation
Note sure that's a good idea, it kind of breaks the abstraction barrier. |
well i'm struggling with the bitbucket apis, which can send data for delete verbs. this kind of apis, which not necessarily respects REST conventions, exist almost every where |
Yeah, that makes more sense. |
500bd33
to
8308805
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ok done. now: all methods (get,head,delete,put,options) have the exact same impl, apart from the VERB (btw options & head use the same verb. shouldnt it be 'OPTIONS in the http-option fun?) |
duh yes, that's a bug! |
care to fix in this pr? |
make http-* take the same args list (http-get, http-delete, http-options)
8308805
to
2bc526a
Compare
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
export http-request for low level http usage.