Remove newline when writing http post/put data #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When writing post data, adding an extra newline may cause some web servers to close the connection before sending a response because the extra newline isn’t accounted for in the post/put data’s content length. Removing the newline seems to fix the problem. This was encountered posting a capabilities document to `chromedriver`’s /session endpoint. An alternate fix is to include the new line in the content-length calculation.
vyzo
approved these changes
Jul 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When writing post data, adding an extra newline may cause some
web servers to close the connection before sending a response
because the extra newline isn’t accounted for in the post/put data’s
content length. Removing the newline seems to fix the problem. This was
encountered posting a capabilities document to
chromedriver’s/session endpoint. An alternate fix is to include the new line in the
content-length calculation.