Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be forgiving when --prefix passed with trailing '/' #513

Merged
merged 1 commit into from
May 21, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 26 additions & 5 deletions src/configure
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,12 @@
(and (<= prefix-len (string-length s))
(string=? prefix (substring s 0 prefix-len)))))

(define (string-ends-with? s suffix)
(let* ((suffix-len (string-length suffix))
(s-len (string-length s)))
(and (<= suffix-len s-len)
(string=? suffix (substring s (- s-len suffix-len) s-len)))))

(define (string-contains? s find)
(let ((find-len (string-length find)))
(let loop ((i 0))
Expand All @@ -57,6 +63,21 @@
(else
(loop (+ 1 i)))))))

(define (path-join base . args)
(fold (lambda (part path)
(let ((starts (string-starts-with? part "/"))
(ends (string-ends-with? path "/")))
(cond
((and starts ends) (string-append path (substring part 1)))
((or starts ends) (string-append path part))
(else (string-append path "/" part)))))
base args))

(define (trim-suffix s suffix)
(if (string-ends-with? s suffix)
(substring s 0 (- (string-length s) (string-length suffix)))
s))

(define (feedback-mid . message-bits)
(display ">>> ")
(for-each display message-bits)
Expand Down Expand Up @@ -117,7 +138,7 @@
(define (shell-patches)
(define (bin-path prefix prog)
(if prefix
(string-append prefix "/bin/" prog)
(path-join prefix "bin" prog)
prog))
`(,(make-patch (string-append "GERBIL_GSI=\"" (bin-path gambit-prefix "gsi") "\"\n")
"GERBIL_GSI="
Expand All @@ -130,12 +151,12 @@

(define (gambit-gsc-path)
(if gambit-prefix
(string-append gambit-prefix "/bin/gsc")
(path-join gambit-prefix "/bin/gsc")
"gsc"))

(define (gerbil-gxc-path)
(if install-prefix
(string-append install-prefix "/bin/gxc")
(path-join install-prefix "/bin/gxc")
"gxc"))

(define (patches)
Expand Down Expand Up @@ -177,10 +198,10 @@
(exit 0))
((match-prefix (car args) "--prefix=") =>
(lambda (new-value)
(set! install-prefix new-value)
(set! install-prefix (trim-suffix new-value "/"))
(loop (cdr args))))
((string=? (car args) "--prefix")
(set! install-prefix (cadr args))
(set! install-prefix (trim-suffix (cadr args) "/"))
(loop (cddr args)))
((match-prefix (car args) "--with-gambit=") =>
(lambda (new-value)
Expand Down