Fix the "Homebrew uses installed libgambit" issue. #1113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for elastic-ritchie-8f47f9 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
build failed. |
|
We really need to get rid of the transient falling SSL test. Out of the
last 50 checks on PR's, 42 or so failed with the badssl not being live
transient not our fault failure.
This one changes nothing about the build or the tests so failing tests are
OUR fault. Sigh.
…On Wed, Jan 24, 2024 at 10:23 PM vyzo ***@***.***> wrote:
build failed.
—
Reply to this email directly, view it on GitHub
<#1113 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADVTXLFGNQIHOIADHOYNETYQH267AVCNFSM6AAAAABCJ33EDGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBZGQZTANBYGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
yar, flaky tests no good -- go ahead and cond-expand it out. |
|
By cond-expand you mean `#;` ? Or "What do I cond expand in order to never
expand?" :)
…On Thu, Jan 25, 2024 at 9:20 AM vyzo ***@***.***> wrote:
yar, flaky tests no good -- go ahead and cond-expand it out.
—
Reply to this email directly, view it on GitHub
<#1113 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADVTXNLASW6DRSBVRMZUNTYQKH5DAVCNFSM6AAAAABCJ33EDGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJQGY2TOMJYGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
just put it in a cond expand arm (enable-badssl-test or something), so that it does not run by default. |
vyzo
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The other commits are a rebase