Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

define vector-ref-set! and u8vector-ref-set! in core prelude #1071

Merged
merged 3 commits into from
Dec 4, 2023

Conversation

leahneukirchen
Copy link
Contributor

I moved the existing documentation, perhaps there's a better place tho.

Copy link

netlify bot commented Dec 4, 2023

👷 Deploy request for elastic-ritchie-8f47f9 pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 2515423

@fare
Copy link
Collaborator

fare commented Dec 4, 2023

I think you are also supposed to export all those things from the suitable modules in prelude/core.ss.

@leahneukirchen
Copy link
Contributor Author

These things have (export #t) no?

@fare
Copy link
Collaborator

fare commented Dec 4, 2023

There's exporting from those particular runtime modules, that will put things in the runtime environment, and then there is exporting from the prelude/core.ss that will make those things visible without explicit importing from the runtime.

@fare
Copy link
Collaborator

fare commented Dec 4, 2023

OK, it looks like I'm confused and you shouldn't need anything else. If you tested that it works in interpreted and compiled code, let's just do it.

Copy link
Collaborator

@fare fare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants