Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flush outputs in main functions #1066

Merged
merged 6 commits into from
Dec 4, 2023
Merged

Flush outputs in main functions #1066

merged 6 commits into from
Dec 4, 2023

Conversation

fare
Copy link
Collaborator

@fare fare commented Dec 3, 2023

Fixes #1064

Copy link

netlify bot commented Dec 3, 2023

Deploy Preview for elastic-ritchie-8f47f9 ready!

Name Link
🔨 Latest commit 648e4f8
🔍 Latest deploy log https://app.netlify.com/sites/elastic-ritchie-8f47f9/deploys/656d747e4447790008acf948
😎 Deploy Preview https://deploy-preview-1066--elastic-ritchie-8f47f9.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

vyzo
vyzo previously requested changes Dec 3, 2023
Copy link
Collaborator

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

driver main is wrong.

Copy link
Collaborator

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to use with-unwind-protect, it does use dynamic-wind under the hood -- see the code in thw runtime.

@fare
Copy link
Collaborator Author

fare commented Dec 3, 2023

Is the code in Gerbil or in Gambit? How much of the runtime can I use with what prefixing?

@vyzo
Copy link
Collaborator

vyzo commented Dec 3, 2023

It is in our runtime and you can use all the runtime symbols in generated code -- just not macros.

@fare fare requested a review from vyzo December 4, 2023 02:26
@fare fare force-pushed the flush branch 2 times, most recently from 9dc17ae to 930070e Compare December 4, 2023 04:44
@fare fare enabled auto-merge (squash) December 4, 2023 07:06
Copy link
Collaborator

@drewc drewc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default output in gxi -e is not flushed
3 participants