Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A working guix package #1062

Merged
merged 1 commit into from
Dec 4, 2023
Merged

A working guix package #1062

merged 1 commit into from
Dec 4, 2023

Conversation

drewc
Copy link
Collaborator

@drewc drewc commented Nov 30, 2023

This works as described in the readme. Should add some toplevel install docs but for 0.18.1 it's fine as is.

Copy link

netlify bot commented Nov 30, 2023

Deploy Preview for elastic-ritchie-8f47f9 ready!

Name Link
🔨 Latest commit bd2c17c
🔍 Latest deploy log https://app.netlify.com/sites/elastic-ritchie-8f47f9/deploys/656d63461a434f0008fa5ef7
😎 Deploy Preview https://deploy-preview-1062--elastic-ritchie-8f47f9.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@fare fare self-requested a review December 1, 2023 00:09
Copy link
Collaborator

@fare fare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

However:

  1. Is make core working for you? Somehow I had to make bootstrap && make from-scratch instead in Nixpkgs.
  2. Shouldn't you be replacing the "gcc" by a hermetic link to a static gcc, as I do in Nixpkgs?
  3. Shouldn't you use --enable-march= to avoid non-portable instructions on a public package?

@drewc
Copy link
Collaborator Author

drewc commented Dec 1, 2023

1. Is make core working for you? Somehow I had to `make bootstrap && make from-scratch` instead in Nixpkgs.

Yes, it's now working fine. For 0.17 I had to build the bootstrap, package that, build gambit, package that, then build.sh gerbil with those deps.

Now it seems to work just by the three steps. However I have not tried to build on all my guix boxes from scratch so it may be working by fluke. I'll make sure.

2. Shouldn't you be replacing the `"gcc"` by a hermetic link to a static gcc, as I do in Nixpkgs?

I'm not sure that's needed.

3. Shouldn't you use `--enable-march=` to avoid non-portable instructions on a public package?

I thought that march-native was to enable mass gcc optimizations? The package is built with gcc on a GNU system. Where did I go wrong?

@fare
Copy link
Collaborator

fare commented Dec 2, 2023

--enable-march=native will work better on the same (kind of) machine that compiles it, at the expense of not working on other machines. So if you have a fancy recent Intel64 CPU, the binary won't run on an old AMD64 CPU, and vice versa.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants