Release file handle when opening new file #272

cdalexndr · 2020-03-10T17:48:55Z

Open file, open new file, try to delete old file => file is till opened in LoselessCut

mifi · 2020-03-19T15:53:30Z

I assume this is on windows, right?

cdalexndr · 2020-03-19T18:13:30Z

Yes, Windows 10

mifi · 2020-03-26T13:34:27Z

I just tested on Windows 8.1 and it works there.

drag drop a file from my desktop into losslesscut
drag drop another file from my desktop (choose open instead)
right click the first file on my desktop and delete it
success

Is this the same as you did?

cdalexndr · 2020-04-03T12:34:11Z

Just reproduced with:

Open file
Select segments and export
File -> Close
App is still running
Try to delete old file

cdalexndr · 2020-04-03T12:44:56Z

It seems it doesn't reproduce every time...

cdalexndr · 2020-04-03T12:57:22Z

Reproduce it again with a ~3h video with 18 segments reduced to ~1h30m

mifi · 2020-04-03T14:32:16Z

When delete gives an error, maybe you could check which process is holding the file open
Whether it is ffmpeg, ffprobe or LosslessCut itself.
https://superuser.com/questions/117902/find-out-which-process-is-locking-a-file-or-folder-in-windows

cdalexndr · 2020-04-03T21:44:17Z

LosslessCut.exe has the file handle blocking delete.

mifi · 2020-04-11T07:30:33Z

I tried again now with the newest version and I'm still not able to reproduce this problem on Windows 8.1. I can even trash the file while it is open in LosslessCut. Could it be some stricter settings in your operating system configuration?

cdalexndr · 2020-04-11T11:09:24Z

Forgot to check what version I'm using. It's 3.13.0.0.
I'll try newest version and report back if it's still a problem.

cdalexndr · 2020-04-15T11:11:21Z

With 3.19.0, the file handle remains open in ffprobe.exe, but it gets released after some time.
I guess there is still pending work for ffprobe.

cdalexndr · 2020-04-15T11:37:55Z

Also managed to reproduce stuck file handle in LoselessCut that doesn't get released.
Same as before, it doesn't reproduce every time.

mifi · 2020-04-18T07:03:05Z

How long do you try to wait before checking the file handle? Does it get released after some time? I know that Windows has a lot of issue with file locking in general compared to MacOS/Linux which doesn't have a concept of locking files.

cdalexndr · 2020-04-18T07:47:24Z

If it's locked by ffprobe.exe it gets released after some time (not much, ~1min).
If it's locked by LoselessCut it doesn't get released and I have to quit the program for the file handle to be released.

mifi · 2020-04-18T07:51:04Z

Ok. Do you see any other patterns? Like did it ever happen from just opening a file and then closing it? Or do you have to cut first for this to happen? Does it happen with only some file types?

cdalexndr · 2020-05-20T11:54:51Z

Just reproduced file handle stuck temporary by ffprobe.exe and also permanently by LoselessCut 3.19.0 with:

Open file
Browse timeline
File -> Close
Cannot delete file

So the editing has nothing to do with file handle getting stuck.
Files are .mkv, 2-3 GB size.

MisterReally · 2021-10-12T23:40:47Z

I am experiencing the same issue consistently.

Windows 10 Enterprise
LosslessCut 3.39.0 (Built locally - not installed from Windows Store)

Clicking the trash icon after editing file of size 433,373 KB displays the following messages in 'Developer Tools' view (I replaced some file path values with a string enclosed with <> for privacy):

react_devtools_backend.js:4049
react_devtools_backend.js:4049
trashResponse
{tmpFiles: true, projectFile: true, sourceFile: true}

Command failed: C:\Users<acsii_string>\AppData\Local\Temp\7dd5c8b8-fe4c-41ff-bda7-7f7313e0caad.tmp.exe D:<ascii_string><ascii_string> 2021-10-12 15_04-cap.mp4

at ChildProcess.exithandler (child_process.js:308)
at ChildProcess.emit (events.js:210)
at maybeClose (internal/child_process.js:1021)
at Process.ChildProcess._handle.onexit (internal/child_process.js:283)

A dialog appears with message: "Unable to move file to trash. Do you want to permanently delete it?

User then selects button labeled "Permanently delete" and receives the following exceptions:

Error: ENOENT: no such file or directory, unlink ' D:<ascii_string><ascii_string> 2021-10-12 15_04-cap-proj.llc'
overrideMethod @ react_devtools_backend.js:4049
Promise.catch (async)
(anonymous) @ main.36c952cf.chunk.js:1
async function (async)
(anonymous) @ main.36c952cf.chunk.js:1
Ve @ 2.02f77fbb.chunk.js:2
Ke @ 2.02f77fbb.chunk.js:2
(anonymous) @ 2.02f77fbb.chunk.js:2
Cr @ 2.02f77fbb.chunk.js:2
wr @ 2.02f77fbb.chunk.js:2
(anonymous) @ 2.02f77fbb.chunk.js:2
Le @ 2.02f77fbb.chunk.js:2
(anonymous) @ 2.02f77fbb.chunk.js:2
Ir @ 2.02f77fbb.chunk.js:2
Jt @ 2.02f77fbb.chunk.js:2
Zt @ 2.02f77fbb.chunk.js:2
t.unstable_runWithPriority @ 2.02f77fbb.chunk.js:2
Vi @ 2.02f77fbb.chunk.js:2
Pe @ 2.02f77fbb.chunk.js:2
Qt @ 2.02f77fbb.chunk.js:2

react_devtools_backend.js:4049 Error: EBUSY: resource busy or locked, unlink ' D:<ascii_string><ascii_string> 2021-10-12 15_04-cap.mp4'
overrideMethod @ react_devtools_backend.js:4049
(anonymous) @ main.36c952cf.chunk.js:1
async function (async)
(anonymous) @ main.36c952cf.chunk.js:1
Ve @ 2.02f77fbb.chunk.js:2
Ke @ 2.02f77fbb.chunk.js:2
(anonymous) @ 2.02f77fbb.chunk.js:2
Cr @ 2.02f77fbb.chunk.js:2
wr @ 2.02f77fbb.chunk.js:2
(anonymous) @ 2.02f77fbb.chunk.js:2
Le @ 2.02f77fbb.chunk.js:2
(anonymous) @ 2.02f77fbb.chunk.js:2
Ir @ 2.02f77fbb.chunk.js:2
Jt @ 2.02f77fbb.chunk.js:2
Zt @ 2.02f77fbb.chunk.js:2
t.unstable_runWithPriority @ 2.02f77fbb.chunk.js:2
Vi @ 2.02f77fbb.chunk.js:2
Pe @ 2.02f77fbb.chunk.js:2
Qt @ 2.02f77fbb.chunk.js:2

mifi · 2021-11-03T05:17:43Z

I think it may be related to this chromium bug:
https://bugs.chromium.org/p/chromium/issues/detail?id=969049

i suspect that it happens when first opening a natively supported file (which creates a <video> tag. Then if later opening a not natively supported file the <video> tag is automatically removed by React but the video is still open in chromium due to that bug. It may have been fixed in newest chromium/electron, but we are being held back from upgrading electron due to macos issues #714

Update:
Seems that chromium bug is fixed already: https://bugs.chromium.org/p/chromium/issues/detail?id=1064749

And I don't think it's what's causing it because <video> is actually never removed from the dom in losslesscut

aCuria · 2022-02-25T15:34:46Z

Same issue with Windows 11, Lossles Cut v3.4.3

"Trash Can" function also does not work for deleting original file

maybe we can have some hack to "restart" the program when the trash can button is hit...

mifi · 2022-02-25T17:05:01Z

@aCuria do you see which program is locking the file? Is it losslesscut.exe or is it ffprobe.exe ? and if you wait for a few minutes, will it resolve?
Also is the file natively supported or converted to supported format?

aCuria · 2022-02-26T03:31:36Z

do you see which program is locking the file?

Error message windows gives is "The action can't be completed because the file is open in LosslessCut"

Is it losslesscut.exe or is it ffprobe.exe ?

ffprobe process does not appear to be running in the task manager

and if you wait for a few minutes, will it resolve?

Not after 5min, and losslesscut cpu usage is at 0% all the way

Also is the file natively supported or converted to supported format?

converted

mifi · 2022-02-26T07:22:45Z

I did some improvements to the Canvas player (unsupported files player) that will hopefully resolve this in the next version

mifi · 2022-03-13T04:32:18Z

Would be nice to see whether the newest version has improved this situation

aCuria · 2022-03-17T20:39:00Z

No change in v3.44...

The bug seems to be related to not closing the original file after proxy generation

mifi · 2022-03-18T05:23:32Z

Is it still LosslessCut.exe holding the file handle, or is it ffmpeg.exe or ffprobe.exe? And does the handle get released after some seconds/minutes?

aCuria · 2022-03-29T03:13:51Z

Yes, LosslessCut is holding the file handle according to windows.

…

On Fri, Mar 18, 2022 at 1:23 PM Mikael Finstad ***@***.***> wrote: Is it still LosslessCut.exe holding the file handle, or is it ffmpeg.exe or ffprobe.exe? — Reply to this email directly, view it on GitHub <#272 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIOVH2LSR3KYYZC3L3WGLWDVAQHN5ANCNFSM4LFEOLWQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.Message ID: ***@***.***>

mifi · 2022-03-29T04:06:46Z

Thank you. Then I honestly don’t know what’s causing it but hopefully after upgrading Electron to the latest version it will be solved.

mikeyaworski · 2022-05-18T07:23:53Z

I've been using release 3.44.0 and still run into this issue. The way I find myself running into it either exporting + deleting videos in a large batch, or exporting videos that are large in size. My typical workflow might be:

Large batch:

Open a batch of 20-40 files
Go through each one, export a portion of it, then delete it
At some point, deleting one of them will fail

Large videos:

Exporting part of a movie (mp4 or mkv) and then deleting

It seems extra likely for deleting to fail if you leave lossless cut open in the background for a while, and then come back to it. This may or may not be true.

mifi · 2022-05-21T19:29:29Z

What's useful to observe in order for me to fix this:

Is it LosslessCut.exe, ffprobe.exe or ffmpeg.exe holding the file lock?
Does the file get released/unlocked after a few minutes?

If 2 is true, it might be possible to workaround this issue by having losslesscut continuously retrying to delete the file in a while-try-catch loop for a few minutes after the delete button is pressed, to remedy these issues on windows.

mikeyaworski · 2022-05-22T00:08:55Z

The Windows prompt says LosslessCut. I'll look closely next time it happens and update this thread.
I don't believe so. I've been working my way through 40 files in a batch before, where one of the first gets locked, and even once I've gone through the rest of the batch, the first is still locked. I'll do a test for this the next time it happens though.

mifi · 2022-05-22T04:48:07Z

If it never gets released and it's LosslessCut.exe that's holding the file handle (and you see no ffmpeg.exe or ffprobe.exe processes in Task Manager), then that's probably an electron bug and nothing I can do about it, but it might be fixed once we upgrade electron to the newest version #714

mikeyaworski · 2022-05-28T04:34:41Z

Writing to confirm that there are no ffmpeg or ffprobe processes in task manager, and it never gets released.

And for clarification, I try to delete the file from within LosslessCut (the d shortcut), and it says it's unable to move the file to trash. I then try to delete it with the Windows File Explorer and it says "The action can't be completed because the file is open in LosslessCut"

mifi · 2022-05-28T21:17:47Z

Even after opening a new file, llc still holds the handle to the old file indefinitely? I hope this will be fixed when we upgrade electron

mikeyaworski · 2022-05-28T23:43:37Z

Yes it does. I need to close LosslessCut before I'm able to delete the file.

mifi · 2022-06-04T03:32:38Z

Update: seems to be a problem also on MacOS, although less visible #1179

fade0ff · 2022-09-08T18:36:59Z

I have a similar problem in Win10 and version 3.46.2 . After exporting a cut version with embedded JPEG, and closing the file with Ctrl+W (or File->Close) I'm regularly unable to delete the original file unless I close LosslessCut. I if use ResMon or Process Explorer to search for the blocking handler, both report LosslessCut.exe twice (!).
These locks also don't disappear after some minutes. The only way to delete the file is to close LosslessCut.
Locks pretty much like the input file handle is not released properly.
This seems to be only a problem for bigger files though. I.e. I can't really reproduce this issue for smallish MP4s, but for those close to 1GB, it seems to happen absolutely every time.

mifi · 2022-11-23T09:41:06Z

If you can try again with the newest version that'd be great. now upgraded to electron 21.

fade0ff · 2022-11-23T17:14:13Z

I tried some larger files with 3.48.2 beta and closing them with Ctrl-W after exporting seems to release the file handle immediately and I can e.g. delete the original file -> seems to work for me. Thanks!

mifi · 2022-11-24T01:51:23Z

great! I'll close this and we can reopen if it's still a problem

mifi added the Cannot reproduce label Mar 29, 2020

mifi mentioned this issue Apr 11, 2020

Mac App Store version: "delete source file" button is not working #303

Closed

mifi added the bug label Apr 18, 2020

This was referenced Oct 29, 2020

failed to trash source file #426

Closed

Cannot Delete Video File After Being Opened and Closed in LosslessCut #488

Closed

mifi mentioned this issue Nov 3, 2021

Files are not closed correctly #912

Closed

This was referenced Nov 14, 2021

Preference for deleting source file confirmation #860

Closed

Upgrade electron to newest #714

Closed

mifi mentioned this issue Feb 24, 2022

Lossless Cut does not close file correctly #1042

Closed

mifi added a commit that referenced this issue Feb 26, 2022

try to improve canvas player #272

4733ba6

mifi mentioned this issue Jun 4, 2022

Empty trash can #1179

Closed

mifi closed this as completed Nov 24, 2022

mifi mentioned this issue Dec 8, 2023

Option to never show "Cleanup Files" #1797

Closed

4 tasks

Release file handle when opening new file #272

Release file handle when opening new file #272

Comments

cdalexndr commented Mar 10, 2020

mifi commented Mar 19, 2020

cdalexndr commented Mar 19, 2020

mifi commented Mar 26, 2020

cdalexndr commented Apr 3, 2020

cdalexndr commented Apr 3, 2020

cdalexndr commented Apr 3, 2020

mifi commented Apr 3, 2020

cdalexndr commented Apr 3, 2020

mifi commented Apr 11, 2020

cdalexndr commented Apr 11, 2020 • edited Loading

cdalexndr commented Apr 15, 2020

cdalexndr commented Apr 15, 2020

mifi commented Apr 18, 2020

cdalexndr commented Apr 18, 2020

mifi commented Apr 18, 2020

cdalexndr commented May 20, 2020

MisterReally commented Oct 12, 2021

mifi commented Nov 3, 2021 • edited Loading

aCuria commented Feb 25, 2022 • edited Loading

mifi commented Feb 25, 2022 • edited Loading

aCuria commented Feb 26, 2022 • edited Loading

mifi commented Feb 26, 2022

mifi commented Mar 13, 2022

aCuria commented Mar 17, 2022

mifi commented Mar 18, 2022 • edited Loading

aCuria commented Mar 29, 2022 via email

mifi commented Mar 29, 2022

mikeyaworski commented May 18, 2022

mifi commented May 21, 2022 • edited Loading

mikeyaworski commented May 22, 2022

mifi commented May 22, 2022 • edited Loading

mikeyaworski commented May 28, 2022

mifi commented May 28, 2022

mikeyaworski commented May 28, 2022

mifi commented Jun 4, 2022

fade0ff commented Sep 8, 2022

mifi commented Nov 23, 2022

fade0ff commented Nov 23, 2022

mifi commented Nov 24, 2022

cdalexndr commented Apr 11, 2020 •

edited

Loading

mifi commented Nov 3, 2021 •

edited

Loading

aCuria commented Feb 25, 2022 •

edited

Loading

mifi commented Feb 25, 2022 •

edited

Loading

aCuria commented Feb 26, 2022 •

edited

Loading

mifi commented Mar 18, 2022 •

edited

Loading

mifi commented May 21, 2022 •

edited

Loading

mifi commented May 22, 2022 •

edited

Loading