Implemented Update svg-sprites.svg syntax Rush#28

Great suggestion and works really well.
midnightveil · Nov 21, 2024 · 1f53328 · 1f53328
1 parent 43701fa
commit 1f53328
Show file tree

Hide file tree

Showing 2 changed files with 599 additions and 794 deletions.
diff --git a/lib/generateSprites.js b/lib/generateSprites.js
@@ -6,17 +6,17 @@ var Promise = require("bluebird"),
   getIconSvg = require("./getIconSvg");
 
 var svgo = new SVGO({
-  removeViewBox: true
+  removeViewBox: false
 });
 
 function generateSprite(name, params) {
 
   return new Promise(function(resolve, reject) {
     svgo.optimize(getIconSvg(params), function(result) {
 
+      var viewBox = result.data.match(/viewBox="(.*?)"/)[0];
       var m = result.data.match('(<path.*\/>)');
-
-      var svgPath = m[1].replace('path', 'path id="fa-' + name + '"');
+      var svgPath = '<symbol id="fa-' + name + '" ' + viewBox + '>' + m[1] + '</symbol>';
 
       resolve(svgPath.replace(/\s*fill="[^"]+"/, ''));
     });
@@ -36,9 +36,8 @@ function generateSprites(glyphs, params) {
   });
   return Promise.all(workChain).then(function(lines) {
     var outSvgSheet = fs.createWriteStream(outPath);
-    outSvgSheet.write('<?xml version="1.0" encoding="utf-8"?>\n');
-    outSvgSheet.write('<svg height="0" width="0" style="position:absolute;margin-left: -100%;">\n');
-    outSvgSheet.write(lines.join('\n'));
+    outSvgSheet.write('<svg xmlns="http://www.w3.org/2000/svg" style="display: none;">\n');
+    outSvgSheet.write('\t' + lines.join('\n\t'));
     outSvgSheet.end('\n<\/svg>\n');
   });
 }