Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in OSS fuzzing #1264

Merged
merged 7 commits into from
Jan 2, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/sast.yml
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
name: 'CodeQL'

on:
push:
pull_request:
push:
schedule:
- cron: '43 3 * * 5'
workflow_dispatch:

permissions:
contents: read
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ permissions:

jobs:
tests:
name: Tests
name: Tests (unit & fuzz)
runs-on: ubuntu-latest

strategy:
Expand All @@ -34,4 +34,4 @@ jobs:

- name: Unit tests
run: |
npm run test:packages:unit
npm run test:packages:all
1,943 changes: 1,024 additions & 919 deletions package-lock.json

Large diffs are not rendered by default.

9 changes: 6 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,10 @@
"test:lint:ci": "ts-standard",
"test:unit": "cd packages/$PACKAGE && npm run test:unit",
"test:benchmark": "cd packages/$PACKAGE && npm run test:benchmark",
"test:packages": "npm run test:packages:typings && npm run test:packages:unit",
"test:packages:unit": "node --test --experimental-test-coverage ./packages/**/__tests__/*.js",
"test:packages": "npm run test:packages:typings && npm run test:packages:all",
"test:packages:all": "node --test --experimental-test-coverage ./packages/**/__tests__/*.js",
"test:packages:unit": "node --test --experimental-test-coverage ./packages/**/__tests__/index.js",
"test:packages:fuzz": "node --test --experimental-test-coverage ./packages/**/__tests__/fuzz.js",
"test:packages:benchmark": "npm run test:benchmark --workspaces",
"test:packages:typings": "ls packages | xargs -I {} tsd packages/{}",
"test:llrt": "cd llrt && npm test",
Expand Down Expand Up @@ -58,13 +60,14 @@
"@commitlint/cli": "^19.0.0",
"@commitlint/config-conventional": "^19.0.0",
"aws-sdk-client-mock": "^4.0.0",
"fast-check": "^3.0.0",
"husky": "^9.0.0",
"lint-staged": "^15.0.0",
"prettier": "^3.0.0",
"tinybench": "^3.0.0",
"ts-standard": "^12.0.0",
"tsd": "^0.31.0",
"typescript": "^5.4.3"
"typescript": "^5.0.0"
},
"workspaces": [
"packages/*"
Expand Down
23 changes: 23 additions & 0 deletions packages/appconfig/__tests__/fuzz.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
import { test } from 'node:test'
import fc from 'fast-check'
import middy from '../../core/index.js'
import middleware from '../index.js'

const handler = middy((event) => event).use(middleware())
const context = {
getRemainingTimeInMillis: () => 1000
}

test('fuzz `event` w/ `object`', async () => {
fc.assert(
fc.asyncProperty(fc.object(), async (event) => {
await handler(event, context)
}),
{
numRuns: 100_000,
verbose: 2,

examples: []
}
)
})
3 changes: 2 additions & 1 deletion packages/appconfig/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,9 @@
"index.d.ts"
],
"scripts": {
"test": "npm run test:unit",
"test": "npm run test:unit && npm run test:fuzz",
"test:unit": "node --test __tests__/index.js",
"test:fuzz": "node --test __tests__/fuzz.js",
"test:benchmark": "node __benchmarks__/index.js"
},
"license": "MIT",
Expand Down
23 changes: 23 additions & 0 deletions packages/cloudwatch-metrics/__tests__/fuzz.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
import { test } from 'node:test'
import fc from 'fast-check'
import middy from '../../core/index.js'
// import middleware from '../index.js' // TODO needs mocking

const handler = middy((event) => event) // .use(middleware())
const context = {
getRemainingTimeInMillis: () => 1000
}

test('fuzz `event` w/ `object`', async () => {
fc.assert(
fc.asyncProperty(fc.object(), async (event) => {
await handler(event, context)
}),
{
numRuns: 100_000,
verbose: 2,

examples: []
}
)
})
3 changes: 2 additions & 1 deletion packages/cloudwatch-metrics/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,9 @@
"index.d.ts"
],
"scripts": {
"test": "npm run test:unit",
"test": "npm run test:unit && npm run test:fuzz",
"test:unit": "node --test __tests__/index.js",
"test:fuzz": "node --test __tests__/fuzz.js",
"test:benchmark": "node __benchmarks__/index.js"
},
"license": "MIT",
Expand Down
22 changes: 22 additions & 0 deletions packages/core/__tests__/fuzz.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
import { test } from 'node:test'
import fc from 'fast-check'
import middy from '../index.js'

const handler = middy((event) => event)
const context = {
getRemainingTimeInMillis: () => 1000
}

test('fuzz `event` w/ `object`', async () => {
fc.assert(
fc.asyncProperty(fc.object(), async (event) => {
await handler(event, context)
}),
{
numRuns: 100_000,
verbose: 2,

examples: []
}
)
})
3 changes: 2 additions & 1 deletion packages/core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,9 @@
"index.d.ts"
],
"scripts": {
"test": "npm run test:unit",
"test": "npm run test:unit && npm run test:fuzz",
"test:unit": "node --test __tests__/index.js",
"test:fuzz": "node --test __tests__/fuzz.js",
"test:benchmark": "node __benchmarks__/index.js",
"test:profile": "node --prof __benchmarks__/index.js && node --prof-process --preprocess -j isolate*.log | speedscope -"
},
Expand Down
23 changes: 23 additions & 0 deletions packages/do-not-wait-for-empty-event-loop/__tests__/fuzz.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
import { test } from 'node:test'
import fc from 'fast-check'
import middy from '../../core/index.js'
import middleware from '../index.js'

const handler = middy((event) => event).use(middleware())
const context = {
getRemainingTimeInMillis: () => 1000
}

test('fuzz `event` w/ `object`', async () => {
fc.assert(
fc.asyncProperty(fc.object(), async (event) => {
await handler(event, context)
}),
{
numRuns: 100_000,
verbose: 2,

examples: []
}
)
})
3 changes: 2 additions & 1 deletion packages/do-not-wait-for-empty-event-loop/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,9 @@
"index.d.ts"
],
"scripts": {
"test": "npm run test:unit",
"test": "npm run test:unit && npm run test:fuzz",
"test:unit": "node --test __tests__/index.js",
"test:fuzz": "node --test __tests__/fuzz.js",
"test:benchmark": "node __benchmarks__/index.js"
},
"license": "MIT",
Expand Down
23 changes: 23 additions & 0 deletions packages/dynamodb/__tests__/fuzz.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
import { test } from 'node:test'
import fc from 'fast-check'
import middy from '../../core/index.js'
import middleware from '../index.js'

const handler = middy((event) => event).use(middleware())
const context = {
getRemainingTimeInMillis: () => 1000
}

test('fuzz `event` w/ `object`', async () => {
fc.assert(
fc.asyncProperty(fc.object(), async (event) => {
await handler(event, context)
}),
{
numRuns: 100_000,
verbose: 2,

examples: []
}
)
})
3 changes: 2 additions & 1 deletion packages/dynamodb/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,9 @@
"index.d.ts"
],
"scripts": {
"test": "npm run test:unit",
"test": "npm run test:unit && npm run test:fuzz",
"test:unit": "node --test __tests__/index.js",
"test:fuzz": "node --test __tests__/fuzz.js",
"test:benchmark": "node __benchmarks__/index.js"
},
"license": "MIT",
Expand Down
23 changes: 23 additions & 0 deletions packages/error-logger/__tests__/fuzz.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
import { test } from 'node:test'
import fc from 'fast-check'
import middy from '../../core/index.js'
import middleware from '../index.js'

const handler = middy((event) => event).use(middleware())
const context = {
getRemainingTimeInMillis: () => 1000
}

test('fuzz `event` w/ `object`', async () => {
fc.assert(
fc.asyncProperty(fc.object(), async (event) => {
await handler(event, context)
}),
{
numRuns: 100_000,
verbose: 2,

examples: []
}
)
})
3 changes: 2 additions & 1 deletion packages/error-logger/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,9 @@
"index.d.ts"
],
"scripts": {
"test": "npm run test:unit",
"test": "npm run test:unit && npm run test:fuzz",
"test:unit": "node --test __tests__/index.js",
"test:fuzz": "node --test __tests__/fuzz.js",
"test:benchmark": "node __benchmarks__/index.js"
},
"license": "MIT",
Expand Down
23 changes: 23 additions & 0 deletions packages/event-normalizer/__tests__/fuzz.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
import { test } from 'node:test'
import fc from 'fast-check'
import middy from '../../core/index.js'
import middleware from '../index.js'

const handler = middy((event) => event).use(middleware())
const context = {
getRemainingTimeInMillis: () => 1000
}

test('fuzz `event` w/ `object`', async () => {
fc.assert(
fc.asyncProperty(fc.object(), async (event) => {
await handler(event, context)
}),
{
numRuns: 100_000,
verbose: 2,

examples: []
}
)
})
3 changes: 2 additions & 1 deletion packages/event-normalizer/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,9 @@
"index.d.ts"
],
"scripts": {
"test": "npm run test:unit",
"test": "npm run test:unit && npm run test:fuzz",
"test:unit": "node --test __tests__/index.js",
"test:fuzz": "node --test __tests__/fuzz.js",
"test:benchmark": "node __benchmarks__/index.js"
},
"license": "MIT",
Expand Down
43 changes: 43 additions & 0 deletions packages/http-content-encoding/__tests__/fuzz.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
import { test } from 'node:test'
import fc from 'fast-check'
import middy from '../../core/index.js'
import middleware from '../index.js'

const handler = middy((event) => event).use(middleware())
const context = {
getRemainingTimeInMillis: () => 1000,
preferredEncoding: 'br'
}

test('fuzz `event` w/ `object`', async () => {
fc.assert(
fc.asyncProperty(fc.object(), async (event) => {
await handler(event, context)
}),
{
numRuns: 100_000,
verbose: 2,

examples: []
}
)
})

test('fuzz `event` w/ `record`', async () => {
fc.assert(
fc.asyncProperty(
fc.record({
body: fc.anything()
}),
async (event) => {
await handler(event, context)
}
),
{
numRuns: 100_000,
verbose: 2,

examples: []
}
)
})
7 changes: 5 additions & 2 deletions packages/http-content-encoding/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,8 @@ const httpContentEncodingMiddleware = (opts) => {

// Encoding not supported, already encoded, or doesn't need to'
const eventCacheControl =
request.event.headers['cache-control'] ??
request.event.headers['Cache-Control']
request.event?.headers?.['cache-control'] ??
request.event?.headers?.['Cache-Control']
if (eventCacheControl?.includes('no-transform')) {
addHeaderPart(response, 'Cache-Control', 'no-transform')
}
Expand All @@ -57,6 +57,9 @@ const httpContentEncodingMiddleware = (opts) => {
!preferredEncoding ||
!supportedContentEncodings.includes(preferredEncoding) ||
!response.body ||
(typeof response.body !== 'string' &&
!Buffer.isBuffer(response.body) &&
!response.body?._readableState) ||
responseCacheControl?.includes('no-transform')
) {
return
Expand Down
3 changes: 2 additions & 1 deletion packages/http-content-encoding/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,9 @@
"index.d.ts"
],
"scripts": {
"test": "npm run test:unit",
"test": "npm run test:unit && npm run test:fuzz",
"test:unit": "node --test __tests__/index.js",
"test:fuzz": "node --test __tests__/fuzz.js",
"test:benchmark": "node __benchmarks__/index.js"
},
"license": "MIT",
Expand Down
Loading
Loading