fix(log): display nested objects in lambda request and response in @middy/input-output-logger #1227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minjie0501
changed the title
|
Thanks for the PR! I like the idea of having the default be more usable out of the box. See my inline comment about proposed changes. Unit tests will also need to be updated before release. |
I don't see any inline comments 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, nested objects, such as identity within the requestContext of the request event, are displayed as [Object] in the logs. This makes it difficult to debug and understand the full structure of the request and response objects.
Updating the logging mechanism to stringify nested objects using JSON.stringify(cloneMessage, null, 2) ensures that all nested objects are properly represented in the logs, making them more readable and informative.