Fixes Reflector issues in newer versions of NestJS #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paooxide
approved these changes
Jan 5, 2022
|
@microud, why was this PR closed? Without this PR, I was not able used |
tukusejssirs
reviewed
Jan 5, 2022
| "rxjs": "^6.3.3" | ||
| "@nestjs/common": "^8.2.0", | ||
| "@nestjs/core": "^8.2.0", | ||
| "mqtt": "^4.3.1", |
There was a problem hiding this comment.
mqtt version 4.3.2 does not work, because they use collections, which modify Map, Set, Array (and probably some other) Node methods. See mqttjs/MQTT.js#1392 and also mikro-orm/mikro-orm#2597 (esp from this comment on).
Suggested change
| "mqtt": "^4.3.1", | |
| "mqtt": "4.3.1", |
|
@tukusejssirs this PR removed |
|
Okay, @microud, could you notify me when you share some progress with the fix? By progress with the fix I mean anything, not necessarily a final fix merged into And please also see this issue with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.