Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Adds 'Report an Issue' menu option #834

Merged
merged 3 commits into from
Feb 10, 2021
Merged

Conversation

ElinorW
Copy link
Contributor

@ElinorW ElinorW commented Feb 9, 2021

Overview

This PR adds a 'Report an Issue' menu option in the settings dropdown.
This option redirects a user to the new issues page on the Graph Explorer repo.

Fixes #771

Demo

When no user is signed in
image

When a user is signed in:
image

Testing Instructions

  • Navigate to the 'More actions' icon
  • Click to see 'Report an Issue' option.
  • Select option to be redirected to Graph Explorer's new issues page.

@ElinorW ElinorW requested a review from thewahome February 9, 2021 10:55
@thewahome
Copy link
Collaborator

@ElinorW what do you think about placing the report an issue button before sign in when signed in?

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2021

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-834.centralus.azurestaticapps.net

@ElinorW
Copy link
Contributor Author

ElinorW commented Feb 9, 2021

@thewahome and what about the select permissions option?
We leave it where it is?

@thewahome
Copy link
Collaborator

@thewahome and what about the select permissions option?
We leave it where it is?

I see what you mean... What if we move the GE related links to the bottom, with a separator and the other ones to the top? Sign out at the last position is more intuitive as it is mostly expected somewhere there

@ElinorW
Copy link
Contributor Author

ElinorW commented Feb 9, 2021

@thewahome and what about the select permissions option?
We leave it where it is?

I see what you mean... What if we move the GE related links to the bottom, with a separator and the other ones to the top? Sign out at the last position is more intuitive as it is mostly expected somewhere there

Updated change:
When a user isn't signed in
image

When a user is signed in
image

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2021

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-834.centralus.azurestaticapps.net

@ElinorW ElinorW merged commit b83a09c into dev Feb 10, 2021
@ElinorW ElinorW deleted the feature/report-issue branch February 10, 2021 08:02
ElinorW added a commit that referenced this pull request Feb 16, 2021
* Fix: support different content types (#814)

* Feature: Add Adaptive cards  JSON Schema code (#828)

* Feature: samples testing (#833)

* Feature: Adds 'Report an Issue' menu option (#834)

* Feature: clickable links on message bar (#835)

* fix: intermittent create page error (#837)

* Fix: Add 'Maximize sidebar' aria-label (#842)

* Task: upgrade technologies (#844)

* Fix: expand maxWidth allow more humanName chars (#764)

* Fix: autocomplete options not displaying (#847)

* fix: adaptive cards destroy (#848)

* Fix: Graph Explorer link colors (#846)

* Fix: Adaptive cards instrumentation (#849)

* Fix: adjust column width (#850)

* Task: prevent storing access token (#851)

Co-authored-by: jobala <[email protected]>
Co-authored-by: Charles Wahome <[email protected]>
Co-authored-by: OfficeGlobal <[email protected]>
Co-authored-by: OfficeGlobal <[email protected]>
Co-authored-by: Azure Static Web Apps <[email protected]>
Co-authored-by: Millicent Achieng <[email protected]>
Co-authored-by: Sébastien Levert <[email protected]>
Co-authored-by: Ezrqn Kemboi <[email protected]>
Co-authored-by: Vincent Biret <[email protected]>
Co-authored-by: Joseph Ngugi <[email protected]>
Co-authored-by: Maggie Kimani <[email protected]>
ElinorW added a commit that referenced this pull request Feb 22, 2021
* Fix: support different content types (#814)

* Feature: Add Adaptive cards  JSON Schema code (#828)

* Feature: samples testing (#833)

* Feature: Adds 'Report an Issue' menu option (#834)

* Feature: clickable links on message bar (#835)

* fix: intermittent create page error (#837)

* HB of localized GE.jsons (#830)

* Fix: Add 'Maximize sidebar' aria-label (#842)

* Task: upgrade technologies (#844)

* Fix: expand maxWidth allow more humanName chars (#764)

* Fix: autocomplete options not displaying (#847)

* fix: adaptive cards destroy (#848)

* Fix: Graph Explorer link colors (#846)

* Fix: Adaptive cards instrumentation (#849)

* Fix: adjust column width (#850)

* Task: prevent storing access token (#851)

* HB of localized GE.jsons (#854)

* chore(release): 4.3.0 (#857)

* Fix: rename component name (#859)

* chore(release): 4.4.0

Co-authored-by: jobala <[email protected]>
Co-authored-by: Charles Wahome <[email protected]>
Co-authored-by: OfficeGlobal <[email protected]>
Co-authored-by: OfficeGlobal <[email protected]>
Co-authored-by: Azure Static Web Apps <[email protected]>
Co-authored-by: Millicent Achieng <[email protected]>
Co-authored-by: Sébastien Levert <[email protected]>
Co-authored-by: Ezrqn Kemboi <[email protected]>
Co-authored-by: Vincent Biret <[email protected]>
Co-authored-by: Joseph Ngugi <[email protected]>
Co-authored-by: Maggie Kimani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "Report an issue" option under settings gear
2 participants