Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task: autocomplete hover styling #801

Merged
merged 2 commits into from
Jan 18, 2021
Merged

Conversation

thewahome
Copy link
Collaborator

Overview

Show the user which autocomplete options is hovered on.

Fixes #725

Demo

Hovering over assignedLicenses
image

Testing Instructions

  • Trigger autocomplete

  • Hover over the available options

  • Notice a change in background colour

  • change theme and notice the effect is as expected

@thewahome thewahome requested review from jobala and ElinorW January 18, 2021 12:24
@thewahome thewahome merged commit d526e94 into dev Jan 18, 2021
thewahome added a commit that referenced this pull request Jan 30, 2021
* Fix - replaces content-type header by accept to match HTTP and avoid CORS pre-flight (#783)

* Fix: modify permissions tab UI (#790)

* Track errors  (#777)

* Fix: sanitize url when fetching permissions (#794)

* Fix: remove wrongly placed working (#795)

* Fix: all permissions show as required (#797)

* Task: autocomplete hover styling (#801)

* Fix: Enable screen reader confirmation feedback (#802)

* Migrate to eslint (#627)

* Feature: resizable components (#766)

* Fix: add onItemInvoked action (#806)

* Fix: permissions consent (#807)

* Task: accessibility ci (#358)

* Fix: prevent resize when view expanded (#816)

* Feature: additional telemetry (#813)

* Fix: permissions tab UI (#815)

* Fix: shrink request section (#822)

Co-authored-by: jobala <[email protected]>
Co-authored-by: OfficeGlobal <[email protected]>
Co-authored-by: OfficeGlobal <[email protected]>
Co-authored-by: Azure Static Web Apps <[email protected]>
Co-authored-by: Elinor <[email protected]>
Co-authored-by: Millicent Achieng <[email protected]>
Co-authored-by: Sébastien Levert <[email protected]>
Co-authored-by: Ezrqn Kemboi <[email protected]>
Co-authored-by: Vincent Biret <[email protected]>
Co-authored-by: Joseph Ngugi <[email protected]>
@thewahome thewahome deleted the task/autocomplete-hover-styling branch February 17, 2021 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autocomplete does not show which option is hovered on.
2 participants