Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: resizing GE layouts #3526

Closed
wants to merge 35 commits into from
Closed

feat: resizing GE layouts #3526

wants to merge 35 commits into from

Conversation

musale
Copy link
Contributor

@musale musale commented Jan 8, 2025 •
edited
Loading

Use https://react.fluentui.dev/?path=/docs/contrib_packages-react-resize-handle--docs to create grids and resize handlers.

ge-grid-layout.mp4

TODO:

  • Add GE components
  • Remove dimension handling from state
  • Cater for tryit experience
  • Make responsive in smaller screens
  • Close feat: migrate response section to fluent UI v9 #3473 first. It's the parent to this branch. I needed to change resizing to ensure that display properties used in the response area are working correctly.

musale added 30 commits November 28, 2024 17:50
@musale
feat: add new components for Monaco and response display in v9
2aa1628
@musale
feat: implement Monaco v9 editor and enhance response display functio…
2ec1728 
…nality
@musale
feat: implement ResponseV9 component and update pivot items to use it
8e40ecb
@musale
feat: add OneNote and PDF content types, update response headers hand…
c5a8cea 
…ling, and enhance response display components
@musale
feat: add @microsoft/microsoft-graph-types dependency, update respons…
4934e83 
…e handling, and improve type safety in graph request functions
@musale
feat: update graph response handling to initialize headers and remove…
f2d4bbe 
… unused response headers in history item
@musale
Merge branch 'feat/fluent-v9-upgrade' into feat/response-v9
1fdc231
@musale
Use a Record to allow serialization of headers
dd7ffa6
@musale
refactor: update response handling to use ResponseBody type and impro…
06c6133 
…ve header processing
@musale
feat: add CopyButtonV9 and ResponseHeadersV9 components, update compo…
ee93483 
…nent registry
@musale
feat: introduce SnippetV9 and CopyButtonV9 components, update related…
093d8ea 
… imports and types
@musale
feat: enhance MonacoV9 and SnippetsV9 components with extra informati…
ada6582 
…on display and improved styling
@musale
feat: add GraphToolkitV9 component and integrate it into pivot items
719a95e
@musale
refactor: remove unused styledGraphToolkit definition from GraphToolk…
48651dc 
…itV9 component
@musale
refactor: update adaptive cards lookup and improve error handling in …
3e24781 
…adaptive card utilities
@musale
refactor: clean up imports and reorganize state selection in Adaptive…
f8e4032 
…CardV9 component
@musale
WIP: back from leave
a1609c5
@musale
Merge branch 'feat/fluent-v9-upgrade' into feat/response-v9
ca176fa
@musale
refactor: Update imports and clean up code formatting in QueryRespons…
4fa32da 
…e and App components
@musale
refactor: Simplify QueryResponse component by returning GetPivotItems…
64a4424 
… directly
@musale
refactor: Restore GetPivotItems usage and reintroduce QueryResponse l…
163aa75 
…ayout
@musale
refactor: Introduce QueryResponseV9 component and update App to use it
6665ff1
@musale
refactor: Add Layout component and integrate it into App, enhancing s…
f9d2351 
…tructure and responsiveness
@musale
refactor: Update Layout component to improve sidebar and response are…
0c03312 
…a reset functionality
@musale
refactor: Update Layout and MainHeaderV9 components for improved stru…
4c6753d 
…cture and styling
@musale
refactor: Enhance Layout and SidebarV9 components for improved stylin…
2caca7e 
…g and functionality
@musale
refactor: Update SidebarV9 and Layout components for improved styling…
08b16b0 
… and layout adjustments
@musale
refactor: Adjust positioning and padding in Handle and Layout compone…
bef8f66 
…nts for improved layout consistency
@musale
refactor: Update SidebarV9 component to use updated icon imports for …
b33ecc2 
…consistency
@musale
refactor: Enhance Layout component with notification integration and …
fb966fa 
…style adjustments
@musale musale linked an issue Jan 9, 2025 that may be closed by this pull request
Migrate resizing of the GE layout #3528
Open
@musale
Copy link
Contributor Author

musale commented Jan 14, 2025

Closing in favor of #3531. This had gone too far 😅

@musale musale closed this Jan 14, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
2.9% Coverage on New Code (required ≥ 80%)
3.4% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate resizing of the GE layout
1 participant
@musale