Fix: Support unicode characters #2758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Onokaev
previously approved these changes
Aug 30, 2023
calebkiage
reviewed
Aug 30, 2023
src/app/views/query-runner/query-input/auto-complete/auto-complete.util.ts
Outdated
Show resolved
Hide resolved
ElinorW
approved these changes
Sep 7, 2023
Onokaev
approved these changes
Sep 7, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Merged
This was referenced Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #2756
Notes
The ABNF parser is unable to correctly validate the characters in the URL and crashes.
Adding a try catch block ensures the page fails gracefully since a failure in validation should not break the experience
Testing Instructions
https://graph.microsoft.com/v1.0/me/💕