Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task: Make resources tab consistent with kiota vs code openapi explorer #2680

Merged
merged 16 commits into from
Oct 16, 2023
Merged

Task: Make resources tab consistent with kiota vs code openapi explorer #2680

merged 16 commits into from
Oct 16, 2023

Conversation

Onokaev
Copy link
Contributor

@Onokaev Onokaev commented Jul 11, 2023 •
edited
Loading

Overview

Closes #2641

Demo

Notes

Optional. Ancillary topics, caveats, alternative strategies that didn't work out, anything else.

Testing Instructions

  • How to test this PR
    Click on the Resources tab
    Notice the changes in icons and links

@Onokaev Onokaev requested a review from a team as a code owner July 11, 2023 16:13
@Onokaev Onokaev changed the title Change resources tab nav icons Make resources tab consistent with kiota vs code openapi explorer Jul 11, 2023
@Onokaev Onokaev changed the title Make resources tab consistent with kiota vs code openapi explorer Task: Make resources tab consistent with kiota vs code openapi explorer Jul 12, 2023
ElinorW
ElinorW requested changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@ElinorW ElinorW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Onokaev,
So we need the methods to come after the children. For example the GET and PATCH should come after the edge, serviceAnnouncement and sharepoint nodes
Also, I'm not sure the icons were supposed to change 😅

@darrelmiller
Copy link
Contributor

@ElinorW The methods should come before the child path segments. This is because sometimes there are many child path segments and it is hard to find the methods. Originally the VS Code extension didn't work like this but we asked Vincent to change it. And that icon is going away in VS Code, so we definitely shouldn't copy it.

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2680.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2680.centralus.azurestaticapps.net

1 similar comment
@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2680.centralus.azurestaticapps.net

@ElinorW
Copy link
Contributor

ElinorW commented Jul 17, 2023 •
edited
Loading

@ElinorW The methods should come before the child path segments. This is because sometimes there are many child path segments and it is hard to find the methods. Originally the VS Code extension didn't work like this but we asked Vincent to change it. And that icon is going away in VS Code, so we definitely shouldn't copy it.

@darrelmiller Oh I see... this hadn't been updated on the issue. Thank you for clarifying this 🙂
Should we retain the method colors (like the blue on GET) or we just leave it as is?

@ElinorW ElinorW self-requested a review July 18, 2023 16:58
@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2680.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2680.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2680.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2680.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2680.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2680.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2680.centralus.azurestaticapps.net

@Onokaev Onokaev merged commit 0698978 into dev Oct 16, 2023
@Onokaev Onokaev deleted the task/change-resources-buttons branch October 16, 2023 12:51
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@thewahome thewahome mentioned this pull request Oct 17, 2023
Closed
@thewahome thewahome mentioned this pull request Nov 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElinorW ElinorW ElinorW approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resources tree consistency
4 participants
@Onokaev @darrelmiller @ElinorW @thewahome