Task: add telemetry instrumentation #1302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thewahome
requested review from
adhiambovivian,
ddyett,
ElinorW and
millicentachieng
as code owners
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-1302.centralus.azurestaticapps.net |
millicentachieng
requested changes
Dec 9, 2021
There was a problem hiding this comment.
@thewahome Please note the naming convention for the component names. If the event type is LISTITEM_CLICK_EVENT then the component name should end with '*list item', BUTTON_CLICK_EVENT, '*button' etc
Also, actions denote a process often a method. e.g. fetching code snippets.
|
We have some warnings raised by GitHub actions mainly on unused variables. We can have those variables removed. |
millicentachieng
force-pushed
the
task/resource-telemetry
branch
from
59d8a17 to
882ae0e
Compare
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-1302.centralus.azurestaticapps.net |
|
SonarCloud Quality Gate failed. |
millicentachieng
approved these changes
Dec 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes #1300