Enhancement: Add copy button confirmation #1291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElinorW
requested review from
adhiambovivian,
ddyett,
millicentachieng and
thewahome
as code owners
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-1291.centralus.azurestaticapps.net |
thewahome
requested changes
Dec 2, 2021
There was a problem hiding this comment.
The implementation of the copy feedback should be consolidated in one button that can be reused in the different locations.
The button can handle its own state regarding whether the copy has been clicked or not and also the time-out.
This would help keep the implementation DRY.
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-1291.centralus.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-1291.centralus.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-1291.centralus.azurestaticapps.net |
thewahome
reviewed
Dec 3, 2021
thewahome
approved these changes
Dec 3, 2021
Co-authored-by: Charles Wahome <[email protected]>
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-1291.centralus.azurestaticapps.net |
1 similar comment
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-1291.centralus.azurestaticapps.net |
|
SonarCloud Quality Gate failed. |
Onokaev
added a commit
that referenced
this pull request
Dec 9, 2021
* chore: handover translations 202111211330 (#1248) * chore: handover translations 202111191330 (#1242) * chore: handover translations 202111201030 (#1246) * chore: handover translations 202111202230 (#1247) * chore: change the frequency of dependabot updates (#1259) * Task: add build step to linter workflow (#1267) * Task/sonar cloud analysis (#1270) * Fix: November Dependabot updates (#1274) * Chore(deps): Bump jest-watch-typeahead from 0.2.1 to 0.5.0 (#1199) * Chore(deps): Bump @axe-core/webdriverjs from 4.2.2 to 4.3.1 (#1192) * Chore(deps-dev): Bump react-test-renderer from 16.8.3 to 16.13.0 (#1195) * Chore(deps): Bump eslint-plugin-flowtype from 2.50.1 to 2.50.3 (#1198) * Chore(deps): Bump re-resizable from 6.9.0 to 6.9.1 (#1197) * Chore(deps): Bump terser-webpack-plugin from 3.1.0 to 4.2.3 (#1196) * Chore(deps): Bump file-loader from 2.0.0 to 6.2.0 (#1194) * Chore(deps-dev): Bump @types/react from 16.8.3 to 17.0.35 (#1219) * Chore(deps): Bump react from 16.8.2 to 16.14.0 (#1193) * Chore(deps-dev): Bump enzyme-adapter-react-16 from 1.9.1 to 1.15.6 (#1223) * Chore(deps-dev): Bump enzyme-adapter-react-16 from 1.9.1 to 1.15.6 * Chore(deps-dev): Bump @types/enzyme from 3.9.0 to 3.10.10 (#1225) * Chore(deps-dev): Bump ws from 8.0.0 to 8.2.3 (#1226) * Chore(deps): Bump webpack from 4.28.3 to 4.46.0 (#1227) * Chore(deps): Bump @azure/msal-browser from 2.12.0 to 2.19.0 (#1253) * Chore(deps): Bump @microsoft/applicationinsights-web from 2.3.1 to 2.7.1 (#1230) * Chore(deps-dev): Bump serialize-javascript from 3.1.0 to 6.0.0 (#1231) * Chore(deps-dev): Bump @typescript-eslint/eslint-plugin-tslint from 4.15.0 to 4.33.0 (#1232) * Chore(deps-dev): Bump axios from 0.21.4 to 0.24.0 (#1240) * Chore(deps): Bump postcss-preset-env from 6.5.0 to 6.7.0 (#1228) * Chore(deps-dev): Bump @typescript-eslint/parser from 4.15.0 to 4.33.0 (#1243) * Chore(deps-dev): Bump standard-version from 8.0.2 to 9.3.2 (#1245) * Chore(deps-dev): Bump react-test-renderer from 16.13.0 to 16.14.0 (#1265) * Chore(deps-dev): Bump @types/react-redux from 7.1.0 to 7.1.20 (#1264) * Chore(deps-dev): Bump @types/selenium-webdriver from 4.0.6 to 4.0.16 (#1263) * Chore(deps-dev): Bump @types/react-dom from 16.8.2 to 17.0.11 (#1262) * Chore(deps): Bump html-webpack-plugin from 4.0.0-alpha.2 to 4.5.2 (#1261) * Chore(deps): Bump postcss-preset-env from 6.5.0 to 6.7.0 (#1260) * Chore(deps): Bump @fluentui/react from 8.28.0 to 8.43.0 (#1258) * Chore(deps-dev): Bump node-notifier from 8.0.1 to 10.0.0 (#1255) * Chore(deps): Bump jest from 23.6.0 to 27.3.1 (#1244) * Fix: Dropdown Accessibility issue (#1275) * Feature: resource explorer (#1128) * Task: add status message for anonymous queries (#1278) * fix failing coverage information collection (#1279) * Task: Export selected resources to postman collection (#1277) * fix: restore request section behavior (#1292) * Enhancement: Add copy button confirmation (#1291) * Fix selecting query option in autocomplete dropdown causing crash (#1301) * Fix: return blue dots on supported tabs (#1303) * Task: Remove resources tab (#1304) * Fix: Add validation for whitespaces included in a query Url (#1305)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #1103
This enhances the UI/UX by ensuring a user receives a confirmation when they click the copy button at either of these areas
Demo
before clicking copy icon
after clicking copy Icon
Notes
These icons have a set timer and reset after 3 seconds when clicked.
Tooltip changes from 'Copy' to 'Copied'
Testing Instructions