Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add correct project reference in IncidentBot to fix builds #200

Closed
wants to merge 1 commit into from

Conversation

alexpls
Copy link

@alexpls alexpls commented Apr 1, 2020

Updates the Sample.Common.Beta project reference to match the project that has been added to the IncidentBot solution. This gets the solution building again, without it this error is thrown during build:

Severity	Code	Description	Project	File	Line	Suppression State
Error	NU1105	Unable to find project information for 'C:\Users\alexp\Source\Repos\microsoft-graph-comms-samples\Samples\Common\Sample.Common\Sample.Common.csproj'. If you are using Visual Studio, this may be because the project is unloaded or not part of the current solution so run a restore from the command-line. Otherwise, the project file may be invalid or missing targets required for restore.	IncidentBot	C:\Users\alexp\Source\Repos\microsoft-graph-comms-samples\Samples\V1.0Samples\RemoteMediaSamples\IncidentBot\IncidentBot.csproj	1	

Note the Sample.Common.Beta project uses beta versions of the Microsoft Graph API (1.2.0-beta.1) which are now outdated. This PR is just around making the smallest change possible to get IncidentBot building, so I figure updating the dependencies is out of scope.

Updates the Common project reference to match the project that has been added to the `IncidentBot` solution.

Note the "beta" project uses beta versions of the Microsoft Graph API (1.2.0-beta.1) which are now outdated.
@msftclas
Copy link

msftclas commented Apr 1, 2020

CLA assistant check
All CLA requirements met.

@alexpls
Copy link
Author

alexpls commented Apr 20, 2020

Closing as the changes in this PR have now been added to master as part of #202

@alexpls alexpls closed this Apr 20, 2020
@alexpls alexpls deleted the incidentBot branch April 20, 2020 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants