Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for arm64 builds #390

Merged
merged 41 commits into from
Sep 25, 2024
Merged

Add support for arm64 builds #390

merged 41 commits into from
Sep 25, 2024

Conversation

mtfriesen
Copy link
Contributor

@mtfriesen mtfriesen commented Sep 26, 2023

Build arm64 in CI. Installer support to be added later (once #391 is completed).

Progress towards #153

@mtfriesen mtfriesen added the build Related to building/compiling the code label Sep 26, 2023
nibanks
nibanks previously approved these changes Sep 26, 2023
Copy link
Member

@nibanks nibanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/nmr/nmr.vcxproj Outdated Show resolved Hide resolved
src/nmr/nmr.vcxproj Outdated Show resolved Hide resolved
src/nmr/nmr.vcxproj Outdated Show resolved Hide resolved
nibanks
nibanks previously approved these changes Sep 26, 2023
@mtfriesen mtfriesen marked this pull request as ready for review September 26, 2023 19:12
@mtfriesen mtfriesen requested a review from a team as a code owner September 26, 2023 19:12
@mtfriesen mtfriesen enabled auto-merge (squash) September 26, 2023 19:12
nibanks
nibanks previously approved these changes Sep 26, 2023
@mtfriesen mtfriesen disabled auto-merge December 5, 2023 16:48
@nigriMSFT
Copy link
Contributor

FYI the introduction of using win-net-test tools in 11f6d1b means that those tools need to build and release arm64 artifacts. This is not supported currently but should be easy to add. The win-net-test tools are built for arm64 in the OneBranch CI, but not in the github CI

@mtfriesen mtfriesen marked this pull request as draft July 18, 2024 13:19
@mtfriesen mtfriesen added the feature request New feature or request label Jul 18, 2024
nibanks
nibanks previously approved these changes Sep 20, 2024
@mtfriesen mtfriesen mentioned this pull request Sep 23, 2024
@mtfriesen mtfriesen marked this pull request as ready for review September 25, 2024 12:42
Copy link
Member

@nibanks nibanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mtfriesen mtfriesen enabled auto-merge (squash) September 25, 2024 13:40
@mtfriesen mtfriesen merged commit b7d2e3a into main Sep 25, 2024
39 checks passed
@mtfriesen mtfriesen deleted the mtfriesen/arm64 branch September 25, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to building/compiling the code feature request New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants