filter out snapshot from VirtualSystemSettingData #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madhanrm
approved these changes
Feb 13, 2025
liwonMS
approved these changes
Feb 13, 2025
blairurish
reviewed
Feb 13, 2025
|
|
||
| // filter out the snapshot realized system type | ||
| if systemType != "Microsoft:Hyper-V:Snapshot:Realized" { | ||
| return vssd, nil |
There was a problem hiding this comment.
if we find the instance we're looking for before the end of the list, won't we leak the wmi instances after this one? Seems like it would be safer to just clone the one we want to return then defer close the whole collection.
There was a problem hiding this comment.
yes, that is possible, will update PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If virtual machine has checkpoint we currently return first result which can belong to VM or checkpoint. This will cause unexpected failures while deleting or resizing virtual machine. This pull request fixes this issue by filtering out snapshots.