-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Android Studio #843
Add Android Studio #843
Conversation
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
felipecassiors The package manager bot determined there was an issue with one of the installers listed in the url field, and cannot continue. Here are some common causes for this failure you should consider:
|
/AzurePipelines run |
Commenter does not have sufficient privileges for PR 843 in repo microsoft/winget-pkgs |
It seems to be a false positive, the installation runs fine here, despite the status code issue explained in the PR description. @denelon @KevinLaMS, can you please take a look? See it in action through this GIF with 2:30 of duration 😁. Test made with #827 |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
This submission has moved to manual review. |
this package seems to install correctly but we get an error 1223. I suspect this error would be OK to ignore. |
This is an old PR so I'm not sure if the version of Android Studio is still current (maybe the older version is worth having in the repository). The schema needs to be updated, and if the error code referenced is still a success result, that can be added to the manifest so the client doesn't error out. |
Well, there is https://github.com/microsoft/winget-pkgs/tree/master/manifests/g/Google/AndroidStudio, so I'm abandoning this. |
Android Studio installer is Nullsoft.
It exits with status code 1223, and this is a known issue of many Nullsoft based installers when using the
/S
switch. However, the installation goes fine.Either the
winget
should consider 1223 as a success code in case of Nullsoft, or the Android Studio team has to fix it.I submitted an issue in Android Studio's issue tracker for that. See https://issuetracker.google.com/issues/157286802.
This pull request duplicates #132.
Microsoft Reviewers: Open in CodeFlow