Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Android Studio #843

Closed
wants to merge 1 commit into from
Closed

Add Android Studio #843

wants to merge 1 commit into from

Conversation

felipecrs
Copy link
Contributor

@felipecrs felipecrs commented May 23, 2020

Android Studio installer is Nullsoft.

It exits with status code 1223, and this is a known issue of many Nullsoft based installers when using the /S switch. However, the installation goes fine.

Either the winget should consider 1223 as a success code in case of Nullsoft, or the Android Studio team has to fix it.

I submitted an issue in Android Studio's issue tracker for that. See https://issuetracker.google.com/issues/157286802.

This pull request duplicates #132.

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Binary-Validation-Error An error was encountered during the Installers Scan pipeline step. label May 23, 2020
@ghost
Copy link

ghost commented May 23, 2020

felipecassiors The package manager bot determined there was an issue with one of the installers listed in the url field, and cannot continue.

Here are some common causes for this failure you should consider:

  1. The Sha256 HASH in the manifest does not match the HASH of the installer. Run winget hash to generate the hash.
  2. The URL is not valid. Make sure the URL to the installer is publicly available and valid.
  3. The installer has been identified as malware. If the installer is detected as malware, you can submit the installer to the defender team for analysis as a potential false positive.

@felipecrs
Copy link
Contributor Author

/AzurePipelines run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 843 in repo microsoft/winget-pkgs

@felipecrs
Copy link
Contributor Author

felipecrs commented May 23, 2020

It seems to be a false positive, the installation runs fine here, despite the status code issue explained in the PR description. @denelon @KevinLaMS, can you please take a look?

See it in action through this GIF with 2:30 of duration 😁.

VQhKGLsuF9

Test made with #827

@KevinLaMS KevinLaMS removed the Binary-Validation-Error An error was encountered during the Installers Scan pipeline step. label Jul 18, 2020
@KevinLaMS
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label Jul 18, 2020
@ghost ghost assigned KevinLaMS Jul 18, 2020
@ghost
Copy link

ghost commented Jul 18, 2020

This submission has moved to manual review.

@KevinLaMS
Copy link
Contributor

this package seems to install correctly but we get an error 1223. I suspect this error would be OK to ignore.
microsoft/winget-cli#137

@KevinLaMS KevinLaMS added Blocking-Issue Manifest validation is blocked by a known issue. and removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. labels Jul 18, 2020
@perplexityjeff perplexityjeff mentioned this pull request Aug 10, 2020
4 tasks
@jedieaston jedieaston mentioned this pull request Sep 29, 2020
@denelon
Copy link
Contributor

denelon commented May 4, 2021

This is an old PR so I'm not sure if the version of Android Studio is still current (maybe the older version is worth having in the repository). The schema needs to be updated, and if the error code referenced is still a success result, that can be added to the manifest so the client doesn't error out.

@felipecrs
Copy link
Contributor Author

felipecrs commented May 4, 2021

@felipecrs felipecrs closed this May 4, 2021
@felipecrs felipecrs deleted the android-studio branch May 4, 2021 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocking-Issue Manifest validation is blocked by a known issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants