Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manifest for ZAP #756

Merged
merged 15 commits into from
Aug 17, 2023
Merged

Conversation

psiinon
Copy link
Contributor

@psiinon psiinon commented May 22, 2020

Signed-off-by: Simon Bennetts [email protected]

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@msftclas
Copy link

msftclas commented May 22, 2020

CLA assistant check
All CLA requirements met.

@ghost
Copy link

ghost commented May 22, 2020

psiinon The package manager bot determined that the metadata was not compliant. Be sure to use a tool like VSCode (https://code.visualstudio.com/) to make sure your request is YAML syntax is correct. Please also verify the manifest file is compliant with the package manager specification (https://docs.microsoft.com/windows/package-manager/package)
For details on the error, see the details link below in the build pipeline.

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label May 22, 2020
@ghost
Copy link

ghost commented May 22, 2020

psiinon The package manager bot determined that the metadata was not compliant. Be sure to use a tool like VSCode (https://code.visualstudio.com/) to make sure your request is YAML syntax is correct. Please also verify the manifest file is compliant with the package manager specification (https://docs.microsoft.com/windows/package-manager/package)
For details on the error, see the details link below in the build pipeline.

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label May 22, 2020
@ghost
Copy link

ghost commented May 22, 2020

psiinon The package manager bot determined that the metadata was not compliant. Be sure to use a tool like VSCode (https://code.visualstudio.com/) to make sure your request is YAML syntax is correct. Please also verify the manifest file is compliant with the package manager specification (https://docs.microsoft.com/windows/package-manager/package)
For details on the error, see the details link below in the build pipeline.

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label May 22, 2020
@ghost
Copy link

ghost commented May 22, 2020

psiinon The package manager bot determined that the metadata was not compliant. Be sure to use a tool like VSCode (https://code.visualstudio.com/) to make sure your request is YAML syntax is correct. Please also verify the manifest file is compliant with the package manager specification (https://docs.microsoft.com/windows/package-manager/package)
For details on the error, see the details link below in the build pipeline.

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@psiinon
Copy link
Contributor Author

psiinon commented Aug 16, 2023

OK, have applied those 2 suggestions...

@wingetbot wingetbot added the Validation-Installation-Error Error installing application label Aug 16, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello @psiinon,

The package manager bot determined there was an issue with installing the application correctly. Please check the application installs correctly. Once repaired, please push an update to your pull request.

Template: msftbot/validationError/installation/general

@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

Installation failed with exit code -1978334972
2023-08-16 00:36:22.254 [CLI ] ShellExecute installer failed: 83
image

@stephengillie stephengillie self-assigned this Aug 17, 2023
@stephengillie
Copy link
Collaborator

Manual Validation couldn't replicate the error. The package installed and launched normally.

@stephengillie
Copy link
Collaborator

@wingetbot waivers Add Validation-Installation-Error

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed Validation-Installation-Error Error installing application Needs-Author-Feedback This needs a response from the author. labels Aug 17, 2023
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Aug 17, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot enabled auto-merge (squash) August 17, 2023 21:34
@microsoft-github-policy-service
Copy link
Contributor

psiinon,

The check-in policies require a moderator to approve PRs from the community.

Our moderators are community volunteers, please be patient and allow them sufficient time to review your submission.

Template: msftbot/requiresApproval/moderator

@microsoft-github-policy-service microsoft-github-policy-service bot merged commit ad11eb2 into microsoft:master Aug 17, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Aug 17, 2023
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@psiinon
Copy link
Contributor Author

psiinon commented Aug 18, 2023

Woohoo!
Thanks everyone for your assistance getting this merged!

@thc202 thc202 mentioned this pull request Oct 14, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Dependencies Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Validation-Completed Validation passed Waived-Validation-Installation-Error
Projects
None yet
Development

Successfully merging this pull request may close these issues.